-
Notifications
You must be signed in to change notification settings - Fork 3k
Feature/move agent samples and doc #41514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* projects enable_telemetry fix for agents * updating changelog
Update README.md to mention what REST APIs the client library is using, and provide link to REST API reference docs Make sure sync and async inference operations use the same method to calculate inference URL (remove duplicate) As a workaround for service bug, until there is a service fix, modify auto-emitted code to accept 200 as a success code for Datasets DELETE operation. The service should be returning 204 according to TypeSpec, since there is no response payload on success of the delete operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorganizes inference helpers, updates constructors and status handling, removes generated test files, and bumps the package version.
- Refactor: extract
_get_inference_url
and_get_aoai_inference_url
as free functions and update usages. - Cleanup: delete autogenerated tests under
generated_tests
, add return type annotations, accept HTTP 200 on delete, and update telemetry import. - Versioning & metadata: bump to
1.0.0b12
, updatecspell.json
, add.env
template, and includeassets.json
andapiview-properties.json
changes.
Reviewed Changes
Copilot reviewed 152 out of 152 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
generated_tests/* | Remove autogenerated async/sync tests for operations |
azure/ai/projects/operations/_patch_inference.py | Refactor helpers to free functions and update calls |
azure/ai/projects/aio/operations/_patch_inference_async.py | Remove duplicate helpers, update imports |
azure/ai/projects/operations/_operations.py | Add -> None to constructors, extend delete codes |
azure/ai/projects/aio/operations/_operations.py | Extend delete to accept 200 |
azure/ai/projects/_patch_telemetry.py | Correct import path for AIAgentsInstrumentor |
CHANGELOG.md | Bump release to 1.0.0b12 and note telemetry fix |
cspell.json | Add fspath |
azure_ai_projects_tests.template.env | Add endpoint variable template |
assets.json | Add asset repo metadata |
apiview-properties.json | Update service pattern names |
Comments suppressed due to low confidence (5)
sdk/ai/azure-ai-projects/azure/ai/projects/operations/_patch_inference.py:66
- [nitpick] The docstring still refers to
:param input_url:
,:return:
, and classmethod behavior (mentionscls
). Update the docstring to reflect that these are module-level functions rather than class methods.
"""
sdk/ai/azure-ai-projects/generated_tests/test_ai_project_deployments_operations_async.py:1
- All autogenerated tests under
generated_tests
have been deleted. Ensure that equivalent tests are provided elsewhere or that this deletion is intentional to avoid a drop in test coverage.
-# coding=utf-8
sdk/ai/azure-ai-projects/CHANGELOG.md:3
- The changelog section for
1.0.0b12
is empty under Features and Breaking changes. Document the inference refactor, constructor annotations, extended delete status handling, and telemetry import fix under the appropriate headings.
## 1.0.0b12 (Unreleased)
sdk/ai/azure-ai-projects/azure_ai_projects_tests.template.env:13
- [nitpick] The template only includes
AZURE_AI_PROJECTS_TESTS_PROJECT_ENDPOINT
. Consider adding placeholders for subscription, tenant, client ID, and client secret environment variables (e.g.,AIPROJECT_SUBSCRIPTION_ID
) that your tests expect.
# `https://<your-ai-services-account-name>.services.ai.azure.com/api/projects/<your-project-name>`
sdk/ai/azure-ai-projects/azure/ai/projects/operations/_patch_inference.py:25
- The function uses
urlparse
but there’s no import forurlparse
at the top of the module. Addfrom urllib.parse import urlparse
to prevent a NameError at runtime.
def _get_inference_url(input_url: str) -> str:
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines