-
Notifications
You must be signed in to change notification settings - Fork 3k
[Identity] Enable brokered auth in DAC #40335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pvaneck
wants to merge
1
commit into
Azure:main
Choose a base branch
from
pvaneck:identity-dac-broker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+154
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
bf20396
to
e24dd7e
Compare
@xiangyan99 This is the preliminary implementation. Would be good to get your thoughts on:
|
xiangyan99
reviewed
Apr 7, 2025
sdk/identity/azure-identity/azure/identity/_credentials/default.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Apr 7, 2025
sdk/identity/azure-identity/azure/identity/_credentials/default.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- sdk/identity/azure-identity/dev_requirements.txt: Language not supported
xiangyan99
reviewed
Apr 8, 2025
xiangyan99
reviewed
Apr 8, 2025
sdk/identity/azure-identity/azure/identity/_credentials/default.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Apr 8, 2025
sdk/identity/azure-identity/azure/identity/_credentials/default.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
736ae6f
to
670aa2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
InteractiveBrowserBrokerCredential
silent flow authentication to the end of theDefaultAzureCredential
chain. Here, we opt to conditionally add it to the chain only if the broker package is installed.Additional context: https://gist.github.com/christothes/f8a0dc6249261cb36a6c452717c4e932
Closes: #39966