-
Notifications
You must be signed in to change notification settings - Fork 3k
azure-core: remove six dependency #39962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution @akx! We will review the pull request and get back to you soon. |
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR removes the dependency on the unused Python 2/3 compatibility library six from azure-core.
- Updated CHANGELOG.md to reflect the removal of six.
- Removed the six dependency from the install_requires section in setup.py.
Reviewed Changes
File | Description |
---|---|
sdk/core/azure-core/CHANGELOG.md | Updated the changelog entry to notify six has been removed. |
sdk/core/azure-core/setup.py | Removed six from the install_requires dependency list. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Hi @akx thanks for making this PR and restarting the discussion about dropping |
Hi @akx. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hello, bot! Yes, this is still a thing! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
This PR removes the dependency on the
six
Python 2/Python 3 compatibility library inazure-core
, as it doesn't use it.See #36859 for the last attempt about this (autumn 2024), which was approved, and then not merged (?!).
(Also see my previous attempt from 2023, #32248.)
All SDK Contribution checklist:
six
, they should depend on it explicitly.General Guidelines and Best Practices
Testing Guidelines
six
in the core library, there is nothing to test.