Added async settle methods in ServiceBusReceivedMessageContext
as an alternative to the blocking calls
#45426
+501
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ServiceBusReceivedMessageContext
(used byServiceBusProcessorClient
) uses blocking.block()
calls for message settlement which is not ideal in a reactive stack. From the outside the processor seems to support asynchronous handling (using the async client), but internally the settlements methods call.block()
, as mentioned, which turns async processing into blocking I/O. In our case (Kotlin coroutine-based environment), this blocks the entire thread in the dispatcher.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines