Skip to content

Added async settle methods in ServiceBusReceivedMessageContext as an alternative to the blocking calls #45426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahayanm001
Copy link

@ahayanm001 ahayanm001 commented May 21, 2025

Description

ServiceBusReceivedMessageContext (used by ServiceBusProcessorClient) uses blocking .block() calls for message settlement which is not ideal in a reactive stack. From the outside the processor seems to support asynchronous handling (using the async client), but internally the settlements methods call .block(), as mentioned, which turns async processing into blocking I/O. In our case (Kotlin coroutine-based environment), this blocks the entire thread in the dispatcher.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus labels May 21, 2025
Copy link
Contributor

Thank you for your contribution @ahayanm001! We will review the pull request and get back to you soon.

@ahayanm001
Copy link
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant