Skip to content

[Automation] Generate Fluent Lite from Swagger specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/extensionTypes/readme.md#package-preview-2024-11 #45424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented May 21, 2025

[Automation] Generate Fluent Lite from Swagger specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/extensionTypes/readme.md#package-preview-2024-11

azure-sdk added 2 commits May 21, 2025 08:33
…esconfiguration/resource-manager/Microsoft.KubernetesConfiguration/extensionTypes/readme.md#package-preview-2024-11
Copy link
Contributor

github-actions bot commented May 21, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-kubernetesconfiguration-extensiontypes

@v-hongli1 v-hongli1 marked this pull request as ready for review May 22, 2025 01:15
@Copilot Copilot AI review requested due to automatic review settings May 22, 2025 01:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the initial beta release of the Azure Resource Manager ExtensionTypes management client for KubernetesConfiguration. The changes include numerous auto‐generated implementation files, updates to project metadata (pom.xml, versioning, changelog), and sample/documentation updates to support the new package-preview-2024-11.

Reviewed Changes

Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
VersionForReleaseTrainImpl.java Implementation for release train version details.
ResourceManagerUtils.java Utility functions used in paged iterable mapping and ID parsing.
ExtensionTypesMgmtClientImpl.java Main client implementation with long-running operation handling.
ExtensionTypesMgmtClientBuilder.java Builder for the management client.
ExtensionTypesImpl.java, ExtensionTypeImpl.java Implementations for ExtensionTypes and individual ExtensionType.
Fluent models, package-info files, SAMPLE.md, README.md, CHANGELOG.md, etc. Auto-generated files and documentation updates to support the new ExtensionTypes SDK.

return httpHeaders;
}

public Flux<ByteBuffer> getBody() {
Copy link
Preview

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In HttpResponseImpl.getBody(), if responseBody is null, calling ByteBuffer.wrap(responseBody) will throw a NullPointerException. Consider adding a check to return an empty Flux if responseBody is null.

Suggested change
public Flux<ByteBuffer> getBody() {
public Flux<ByteBuffer> getBody() {
if (responseBody == null) {
return Flux.empty();
}

Copilot uses AI. Check for mistakes.

@v-hongli1
Copy link
Member

@XiaofeiCao
The associated issue is marked as HoldOn, Is this PR closed?

@XiaofeiCao
Copy link
Contributor

@XiaofeiCao The associated issue is marked as HoldOn, Is this PR closed?

@v-hongli1 Would you help check if service API is available?

@XiaofeiCao
Copy link
Contributor

@v-hongli1 Please do a regen, as there's a script fix: #45441

@XiaofeiCao XiaofeiCao closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants