Skip to content

Storage Error Codes for Copies #45394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025

Conversation

gunjansingh-msft
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label May 19, 2025
Copy link
Contributor

@ibrandes ibrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far - you should definitely make the change to the queue pom file though so the pipeline can get further into the analyze step :)

@@ -16,7 +16,7 @@ autorest
### Code generation settings
``` yaml
use: '@autorest/java@4.1.42'
input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/30318bc99a721df4ebdfdbf40696739ede75564f/specification/storage/data-plane/Microsoft.BlobStorage/stable/2025-07-05/blob.json
input-file: https://raw.githubusercontent.com/nickliu-msft/azure-rest-api-specs/39829afa70461186963adab664aebd3d9c22971a/specification/storage/data-plane/Microsoft.BlobStorage/stable/2025-11-05/blob.json
Copy link
Contributor

@ibrandes ibrandes May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the specs are merged into main, we should change this to point to azure instead of nick's fork - same for the file share readme

Copy link
Contributor

github-actions bot commented May 20, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-storage-blob
com.azure:azure-storage-file-share

@ibrandes ibrandes self-requested a review May 21, 2025 21:41
Copy link
Contributor

@ibrandes ibrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - the queue test issue with CI needs to be fixed at some point, but that can be resolved after the API views are generated.

@gunjansingh-msft gunjansingh-msft merged commit 822e644 into feature/storage/stg99base May 22, 2025
21 of 36 checks passed
@gunjansingh-msft gunjansingh-msft deleted the errorCodeForCopyBlob branch May 22, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants