-
Notifications
You must be signed in to change notification settings - Fork 103
Update Communication Common SDK for Teams Phone Extensibility identifier #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexandra142
merged 16 commits into
Azure:main
from
alexandra142:feature/apistrak/AddOPS
Jun 12, 2025
Merged
Update Communication Common SDK for Teams Phone Extensibility identifier #1918
alexandra142
merged 16 commits into
Azure:main
from
alexandra142:feature/apistrak/AddOPS
Jun 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods to PhoneNumberIdentifier
AikoBB
reviewed
Jun 11, 2025
AikoBB
reviewed
Jun 11, 2025
...ation-common/src/main/java/com/azure/android/communication/common/PhoneNumberIdentifier.java
Outdated
Show resolved
Hide resolved
AikoBB
reviewed
Jun 11, 2025
...ommon/src/main/java/com/azure/android/communication/common/TeamsExtensionUserIdentifier.java
Outdated
Show resolved
Hide resolved
AikoBB
reviewed
Jun 11, 2025
...ommon/src/test/java/com/azure/android/communication/common/CommunicationIdentifierTests.java
Outdated
Show resolved
Hide resolved
AikoBB
reviewed
Jun 11, 2025
...ommon/src/test/java/com/azure/android/communication/common/CommunicationIdentifierTests.java
Outdated
Show resolved
Hide resolved
AikoBB
reviewed
Jun 11, 2025
- Throw IllegalArgumentException when cloud parameter in SetCloudEnvironment is null
AikoBB
reviewed
Jun 12, 2025
AikoBB
reviewed
Jun 12, 2025
...ommon/src/main/java/com/azure/android/communication/common/TeamsExtensionUserIdentifier.java
Show resolved
Hide resolved
AikoBB
reviewed
Jun 12, 2025
...mmunication-common/src/main/java/com/azure/android/communication/common/ValidationUtils.java
Show resolved
Hide resolved
AikoBB
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just small comments should be resolved
AikoBB
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Communication Common SDK for Teams Phone Extensibility GA
Add support for a new communication identifier
TeamsExtensionUserIdentifier
which maps rawIds with format8:acs:{resourceId}_{tenantId}_{userId}
.Add
isAnonymous
andgetAssertedId
methods toPhoneNumberIdentifier
.