Skip to content

Conversation

ArthurMa1978
Copy link
Member

SDK configuration pull request

Purpose of this PR

  • Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Getting help

  • First, carefully read through this PR description, from top to bottom. Fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@ArthurMa1978 ArthurMa1978 marked this pull request as ready for review October 14, 2025 09:21
Copy link

github-actions bot commented Oct 14, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added resource-manager RPaaS TypeSpec Authored with TypeSpec BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Oct 14, 2025
Copy link

github-actions bot commented Oct 14, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.CodeSigning
TypeSpec Microsoft.CodeSigning
Go sdk/resourcemanager/trustedsigning/armtrustedsigning
C# Azure.ResourceManager.TrustedSigning
JavaScript @azure/arm-trustedsigning
Java com.azure.resourcemanager:azure-resourcemanager-trustedsigning

@ArthurMa1978 ArthurMa1978 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 14, 2025
@ArthurMa1978 ArthurMa1978 removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required BreakingChange-Python-Sdk NotReadyForARMReview labels Oct 14, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Python-Sdk and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 14, 2025
@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Oct 16, 2025
@ArthurMa1978 ArthurMa1978 added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Oct 16, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Oct 16, 2025
@ArthurMa1978 ArthurMa1978 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 16, 2025
@github-actions github-actions bot added ARMAutoSignedOff and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2025
@ArthurMa1978 ArthurMa1978 merged commit 1e76843 into main Oct 16, 2025
67 of 68 checks passed
@ArthurMa1978 ArthurMa1978 deleted the mgmt-codesigning branch October 16, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMAutoSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants