Skip to content

Conversation

skywing918
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

github-actions bot commented Oct 10, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@MaryGao
Copy link
Member

MaryGao commented Oct 10, 2025

@raych1 and @lirenhe Could we update me(marygao) as a code owner for below entry to replace wanlwanl?

/eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts @wanlwanl @raych1 @maririos

https://github.com/azure/azure-rest-api-specs/blob/main/.github/CODEOWNERS#L301

@skywing918 skywing918 requested a review from a team as a code owner October 10, 2025 06:21
@github-actions github-actions bot added ARMReview data-plane resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 10, 2025
Copy link

github-actions bot commented Oct 10, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec ConfidentialLedger
TypeSpec ConfidentialLedgerCertificate
TypeSpec Microsoft.DocumentDB
Java com.azure:azure-confidentialledger
Java com.azure:azure-confidentialledger-certificate
Java com.azure.resourcemanager:azure-resourcemanager-mongocluster
JavaScript @azure-rest/azure-confidentialledger
JavaScript @azure-rest/azure-confidentialledger-certificate
JavaScript @azure/arm-mongocluster

@raych1 raych1 merged commit 2199064 into main Oct 10, 2025
54 of 57 checks passed
@raych1 raych1 deleted the GoSubRuleMessages branch October 10, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview data-plane resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants