-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[Cognitive Services] October Preview ARM API #37813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Curious if you support synchronous delete? If so, include a 200 (OK) response. #Closed Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/preview/2025-10-01-preview/cognitiveservices.json:6047 in 719a515. [](commit_id = 719a515, deletion_comment = False) |
Typo #Closed Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/preview/2025-10-01-preview/cognitiveservices.json:5370 in 719a515. [](commit_id = 719a515, deletion_comment = False) |
I do not see this folder yet. Please push the changes. #Closed Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/preview/2025-10-01-preview/cognitiveservices.json:5362 in 719a515. [](commit_id = 719a515, deletion_comment = False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0e4611b
to
1f9710d
Compare
* Copy files from preview/2025-07-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2025-10-01-preview Updated the API version from preview/2025-07-01-preview to preview/2025-10-01-preview. * Added tag for 2025-10-01-preview in readme file * Add NMS v2 to cogsvc swagger. * Update parameter casing. * Update api versions in examples. * Update NMS parameter properties * Copy over pre-approved suppressions from previous API version. * Add suppressions for NMS v2 swagger additions. * Remove unneeded properties, add provision route * Update accountNameParameter casing. * Update api version in swagger to 2025-10-01-preview. * Consistent naming for package tag in readme. * Prettier gate formatting fix. * Retrigger pipelines * Add summary for outbound rule operation. --------- Co-authored-by: Mike Harder <mharder@microsoft.com>
* Add agentic application to cog services swagger. * Address pipelines. * Fix spellcheck pipeline.
* feat(cognitiveservices): Add deployment pause/resume APIs and service tier management - Add serviceTier enum property to DeploymentProperties (Default, Priority) - Add deploymentState enum property to DeploymentProperties (Running, Paused) - Add POST /deployments/{deploymentName}/pause endpoint for pausing deployments - Add POST /deployments/{deploymentName}/resume endpoint for resuming deployments - Create API examples for pause and resume operations - Update existing deployment examples to include new properties - Add comprehensive descriptions with usage guidance and SKU restrictions - Document HTTP 423 behavior for paused deployments - Mark both operations as idempotent This enables customers to control deployment processing priority through service tiers and pause/resume deployment inferencing for cost optimization and resource management. * need to add pattern for lint errors * deploymentNameForActionParameter
* Update API spec for the Safety provider Get and List APIs * Add webhook URL to the spec * fix duplicate error * address NDA issue * update safetyprovider urls to subscription level * add susbscription level safety provider * Add test connection and sub rai policy * remove unused changes * update format * Update testRaiExternalSafetyProvider endpoint path * update policy name parameter in subscription level * Club together the tags for all safety provider apis * fix prettier error * Fix swagger error * Fix validation errors * Add suppressions --------- Co-authored-by: tparuchuri <tparuchuri@example.com> Co-authored-by: Tejaswi Paruchuri <86433817+Tparuchuri@users.noreply.github.com> Co-authored-by: CJ Ochs <carlochs@microsoft.com>
* Adding spec json for RaiIfcRule get * Add IfcRule and Tool Label feature to cogsvc control plane * Update raiToolLabelNameParameter * Update for RaiIfcRule and RaiToolLabel * Fix required ifcRuleName * Add suppressions for AvoidAdditionalProperties LintDiff flag * Add "hitl" as valid word * Update Enums for source and action in RaiPolicyContentFilter * Remove RaiIfcRule * Add 'hitl' to cspell.yaml dictionary --------- Co-authored-by: CJ Ochs <carlochs@microsoft.com> Co-authored-by: CJ Ochs <111904639+CarlOchs@users.noreply.github.com>
1f9710d
to
31ac723
Compare
31ac723
to
c6426eb
Compare
input-file: | ||
- Microsoft.CognitiveServices/preview/2025-10-01-preview/cognitiveservices.json | ||
suppressions: | ||
- code: ProvisioningStateMustBeReadOnly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure you need these? I dont see this in any other RT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is necessary, it's for the new applications routes that trigger the lintdiff check for provisioningstate must be readonly despite already having it set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be specific to the routes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is specific to the routes with each path, did you have a different path in mind?
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}/applications/{name}"].get.responses.200.schema | ||
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}/applications/{name}"].put.responses.200.schema | ||
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}/applications/{name}"].put.responses.201.schema | ||
- code: ProvisioningStateMustBeReadOnly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also necessary for the new project applications routes, lintdiff trips otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be more specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above, did you have a different path in mind? it's already applied to each route individually where necessary
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}/applications/{appName}/deployments/{deploymentName}"].get.responses.200.schema | ||
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}/applications/{appName}/deployments/{deploymentName}"].put.responses.200.schema | ||
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.CognitiveServices/accounts/{accountName}/projects/{projectName}/applications/{appName}/deployments/{deploymentName}"].put.responses.201.schema | ||
- code: ArmResourcePropertiesBag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
machinelearningservices manifest has the same definition since the managed workspace is essentially being "copied" over:
Lines 6271 to 6287 in d7e4f9f
"OutboundRuleBasicResource": { | |
"required": [ | |
"properties" | |
], | |
"type": "object", | |
"allOf": [ | |
{ | |
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/Resource" | |
} | |
], | |
"properties": { | |
"properties": { | |
"description": "Outbound Rule for the managed network of a machine learning workspace.", | |
"$ref": "#/definitions/OutboundRule" | |
} | |
} | |
}, |
"OutboundRuleBasicResource": {
"required": [
"properties"
],
"type": "object",
"allOf": [
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/Resource"
}
],
"properties": {
"properties": {
"description": "Outbound Rule for the managed network of a machine learning workspace.",
"$ref": "#/definitions/OutboundRule"
}
}
},
reason: This API is copied from Machine Learning Services RP where this behavior is already established. | ||
where: | ||
- $.definitions.OutboundRuleBasicResource | ||
- code: AvoidAdditionalProperties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a previous api version, this is there for a different RT. is this a similar pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the managednetworksettings is unique to the 2025-10-01-preview api version, so it's a new pattern
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.