Skip to content

Conversation

zedy-wj
Copy link
Member

@zedy-wj zedy-wj commented Aug 20, 2025

This PR migrates the manufacturingplatform specification to the new unified folder structure according to Azure folder structure guidelines.

Changes:

  • Consolidated TypeSpec and Swagger files under resource-manager/Microsoft.ManufacturingPlatform/ManufacturingPlatform/
  • Updated tspconfig.yaml with correct paths and ARM types directory
  • Fixed all common-types references and input-file paths in readme.md
  • Updated the relevant paths in specification/suppressions.yaml file
  • Verified TypeSpec compilation works correctly

Benefits:

  • Unified structure for better maintainability
  • Aligns with Azure folder structure standards
  • Maintains backward compatibility
  • Supports future TypeSpec migration efforts

Copy link

github-actions bot commented Aug 20, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added resource-manager RPaaS SuppressionReviewRequired BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Aug 20, 2025
Copy link

github-actions bot commented Aug 20, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.ManufacturingPlatform
Go sdk/resourcemanager/manufacturingplatform/armmanufacturingplatform
Java com.azure.resourcemanager:azure-resourcemanager-manufacturingplatformmanufacturi
JavaScript @azure/arm-manufacturingplatform
Swagger Microsoft.ManufacturingPlatform-ManufacturingPlatform

@zedy-wj zedy-wj added Approved-Avocado Approved-Suppression BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. labels Aug 22, 2025
@zedy-wj zedy-wj marked this pull request as ready for review August 25, 2025 07:02
@github-actions github-actions bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 25, 2025
@ramoka178
Copy link
Contributor

Please fix Swagger Avocado - Analyze Code / Swagger Avocado - Analyze Code (pull_request) error too.

For the next reviewer - I see the commits show mostly file renamings, corresponding path updates till now.

@ramoka178
Copy link
Contributor

ALso, please refrain from adding Approved-LintDiff and Approved-Suppression from your side.

@ramoka178 ramoka178 added ARMChangesRequested and removed Approved-Avocado Approved-Suppression WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 3, 2025
@zedy-wj zedy-wj marked this pull request as draft September 4, 2025 02:22
@github-actions github-actions bot removed the ARMReview label Sep 4, 2025
@zedy-wj
Copy link
Member Author

zedy-wj commented Sep 4, 2025

@ramoka178 - This PR is about FolderMigrationV2. Sorry for the inconvenience. We will re-open it when the batch of this service comes.

@zedy-wj zedy-wj marked this pull request as ready for review October 16, 2025 06:02
@zedy-wj zedy-wj added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review FolderMigrationV2 A specific label for PRs like folder structure migration into v2. labels Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required FolderMigrationV2 A specific label for PRs like folder structure migration into v2. resource-manager RPaaS SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants