Az VMware Powershell Version new 2024-09-01 #27955
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
Updates the Azure VMware PowerShell module to use the 2024-09-01 API version and regenerates related documentation and UX metadata.
- Bumped API version in UX JSON files and updated AutoRest commit & spec path in README
- Added help markdown for new cmdlets (Get-AzVMwareSku, PureStoragePolicy, ProvisionedNetwork, Host) and updated module GUID & cmdlet listings
- Corrected capitalization in existing cmdlet docs and cleaned up AssemblyInfo trailing whitespace
Reviewed Changes
Copilot reviewed 101 out of 101 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/VMware/VMware.Autorest/docs/New-AzVMwareAuthorization.md | Fixed capitalization in synopsis/description |
| src/VMware/VMware.Autorest/docs/Get-AzVMwareSku.md | Added new cmdlet documentation |
| src/VMware/VMware.Autorest/docs/Az.VMware.md | Updated module GUID and expanded cmdlet index |
| src/VMware/VMware.Autorest/UX/Microsoft.AVS/privateClouds.json | Bumped apiVersion to 2024-09-01 |
| src/VMware/VMware.Autorest/README.md | Updated AutoRest commit hash and input-file spec path |
| src/VMware/VMware.Autorest/Properties/AssemblyInfo.cs | Removed extraneous blank lines |
Comments suppressed due to low confidence (6)
src/VMware/VMware.Autorest/docs/Get-AzVMwareSku.md:11
- [nitpick] Align with PowerShell help style by using a verb-first synopsis, e.g., "Gets a list of SKUs."
A list of SKUs.
src/VMware/VMware.Autorest/docs/Get-AzVMwarePureStoragePolicy.md:11
- [nitpick] Align synopsis with cmdlet naming convention, e.g., "Gets a Pure Storage policy."
Get a PureStoragePolicy
src/VMware/VMware.Autorest/docs/Get-AzVMwareProvisionedNetwork.md:11
- [nitpick] Align synopsis with cmdlet naming convention, e.g., "Gets a provisioned network."
Get a ProvisionedNetwork
src/VMware/VMware.Autorest/docs/Get-AzVMwareHost.md:11
- [nitpick] Align synopsis with cmdlet naming convention, e.g., "Gets a host."
Get a Host
src/VMware/VMware.Autorest/UX/Microsoft.AVS/privateClouds-pureStoragePolicies.json:65
- Parameter type is inconsistent—should be an array of strings (
<String[]>) like other cmdlets.
[-SubscriptionId <String>]
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -24,3 +24,7 @@ | |||
| [assembly: System.Reflection.AssemblyVersionAttribute("0.7.2")] | |||
| [assembly: System.Runtime.InteropServices.ComVisibleAttribute(false)] | |||
| [assembly: System.CLSCompliantAttribute(false)] | |||
|
|
|||
There was a problem hiding this comment.
Please remove the empty lines.
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| Describe 'Get-AzVMwareHost' { |
There was a problem hiding this comment.
Please provide at least 1 test case for this cmdlet. If it cannot be recorded, add the test script with -Tag "LiveOnly".
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| Describe 'Get-AzVMwareProvisionedNetwork' { |
There was a problem hiding this comment.
Please provide at least 1 test case for this cmdlet. If it cannot be recorded, add the test script with -Tag "LiveOnly".
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| Describe 'Get-AzVMwarePureStoragePolicy' { |
There was a problem hiding this comment.
Please provide at least 1 test case for this cmdlet. If it cannot be recorded, add the test script with -Tag "LiveOnly".
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| Describe 'Get-AzVMwareSku' { |
There was a problem hiding this comment.
Please provide at least 1 test case for this cmdlet. If it cannot be recorded, add the test script with -Tag "LiveOnly".
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| Describe 'New-AzVMwarePureStoragePolicy' { |
There was a problem hiding this comment.
Please provide at least 1 test case for this cmdlet. If it cannot be recorded, add the test script with -Tag "LiveOnly".
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| Describe 'Remove-AzVMwarePureStoragePolicy' { |
There was a problem hiding this comment.
Please provide at least 1 test case for this cmdlet. If it cannot be recorded, add the test script with -Tag "LiveOnly".
| . ($mockingPath | Select-Object -First 1).FullName | ||
| } | ||
|
|
||
| Describe 'Update-AzVMwarePureStoragePolicy' { |
There was a problem hiding this comment.
Please provide at least 1 test case for this cmdlet. If it cannot be recorded, add the test script with -Tag "LiveOnly".
|
@anaarias-msft Please address the review comments and mask the secrets detected by the security tool in CI. In addition, you should also update the ChangeLog.md with the release notes. |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
Updated the AVS VMware cmdlets to the latest version [2024-09-01] from azure-rest-api-specs using autorest
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.