fix: container build for arm64 and add devcontainer settings for docker in docker #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This test run generated changes to the mock modules in this PR. Please review the changes and merge if appropriate, see #293. |
|
This test run generated changes to the mock modules in this PR. Please review the changes and merge if appropriate, see #294. |
|
This test run generated changes to the mock modules in this PR. Please review the changes and merge if appropriate, see #295. |
|
This test run generated changes to the mock modules in this PR. Please review the changes and merge if appropriate, see #296. |
…rge) (#296) This PR was created by the AVM governance test workflow after pre-commit was run. Please review if the changes should be made to the mock modules: <https://github.com/Azure/avm-terraform-governance/actions/runs/17795914169> Co-authored-by: Azure Verified Modules [bot] <1049636+azure-verified-modules[bot]@users.noreply.github.com>
…merge) (#295) This PR was created by the AVM governance test workflow after pre-commit was run. Please review if the changes should be made to the mock modules: <https://github.com/Azure/avm-terraform-governance/actions/runs/17795914169> Co-authored-by: Azure Verified Modules [bot] <1049636+azure-verified-modules[bot]@users.noreply.github.com>
jaredfholgate
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to container build and test workflows, enhances cross-platform support for ARM64 builds, and updates development environment configurations for better usability and security. The most significant changes are grouped below.
CI/CD Workflow Improvements
.github/workflows/container-release.yml) is now triggered on pull requests to themainbranch, in addition to tags and manual dispatches. This allows container builds and tests to run automatically on PRs..github/workflows/legacy-container-test.yml) has been removed, consolidating container build and test logic into the main workflow.ARM64 Cross-Platform Build Support
container/Dockerfile.azterraform,container/Dockerfile.build) have been updated to install and use the correct cross-compilation toolchain (gcc-aarch64-linux-gnu) when building for ARM64, and to set the appropriate compiler environment variables. This ensures reliable builds for multiple architectures. [1] [2]Dev Container Configuration Enhancements
.devcontainer/devcontainer.jsonfiles inmanaged-files/root,tests/terraform-azure-avm-res-mock, andtests/terraform-azurerm-avm-res-mockhave been updated to add container environment variables, grant additional capabilities (SYS_PTRACE, seccomp unconfined), use host networking, and mount the Docker socket. These changes improve debugging, container management, and compatibility with Docker-in-Docker workflows.Documentation and Editor Settings
./avm pre-commit, ensuring proper workflow for contributors.These updates collectively improve build reliability, developer experience, and CI/CD automation for the project.