Remove hard-coded ingestion batching policies #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To adjust these now, management commands should be used that allows more fine grained polcies.
There was a problem hiding this comment.
Pull Request Overview
This PR removes hard-coded ingestion batching policies from the ADX Syncer and provides documentation for manually configuring these policies through ManagementCommand resources. This change allows for more fine-grained control over ADX ingestion behavior rather than enforcing fixed policies at startup.
Key changes:
- Removes automatic ingestion policy setup from the Syncer component
- Adds comprehensive documentation on how to configure ingestion batching policies manually
- Provides examples for both database-level and table-level policy configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ingestor/adx/syncer.go | Removes the ensureIngestionPolicy function and its call during Syncer initialization |
| docs/cookbook.md | Adds detailed documentation on optimizing ingestion latency with manual policy configuration examples |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jessejlt
requested changes
Oct 16, 2025
jessejlt
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To adjust these now, management commands should be used that allows more fine grained polcies.