Convert width setting value to number #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the type of the variable containing the application's THUMBNAIL_WIDTH setting value from a string to a number since Jimp.resize takes numbers as its parameters. This fixes a bug that crashes the function.
|
This fixes issue #2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the type of the variable containing the application's THUMBNAIL_WIDTH setting value from a string to a number since Jimp.resize takes numbers as its parameters. This fixes a bug that crashes the function.
Purpose
Fix a bug that crashes the function.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?