Skip to content

window deviceManager #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

window deviceManager #267

merged 1 commit into from
Apr 3, 2025

Conversation

chriswhilar
Copy link
Collaborator

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@chriswhilar chriswhilar requested a review from Copilot April 3, 2025 02:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to expose internal objects via the global window for debugging or testing purposes in the MakeCall component.

  • Adds a global assignment for deviceManager
  • Modifies the global variable assignments by maintaining callAgent while removing videoStreamRenderer
Comments suppressed due to low confidence (1)

Project/src/MakeCall/MakeCall.js:158

  • [nitpick] Similarly, exposing callAgent globally could increase the risk of unintended interactions; consider limiting this to development environments to avoid potential issues in production.
window.callAgent = this.callAgent;

@chriswhilar chriswhilar merged commit cc78bb9 into main Apr 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants