Skip to content

Audio effects UI fix #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Audio effects UI fix #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions Project/src/MakeCall/AudioEffects/AudioEffectsContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ export default class AudioEffectsContainer extends React.Component {
stopLoading: false,
noiseSuppressionList: [],
currentSelected: undefined
},
activeEffects: {
autoGainControl: [],
echoCancellation: [],
noiseSuppression: []
}
};

Expand Down Expand Up @@ -92,14 +97,26 @@ export default class AudioEffectsContainer extends React.Component {
});

this.localAudioStreamFeatureApi.on('effectsStarted', (effect) => {
this.updateActiveEffects();
console.log(`Audio effects started: ${JSON.stringify(effect?.name ?? effect)}`);
});

this.localAudioStreamFeatureApi.on('effectsStopped', (effect) => {
this.updateActiveEffects();
console.log(`Audio effects stopped: ${JSON.stringify(effect?.name ?? effect)}`);
});
}

updateActiveEffects() {
this.setState({
activeEffects: {
autoGainControl: this.localAudioStreamFeatureApi?.activeEffects?.autoGainControl,
echoCancellation: this.localAudioStreamFeatureApi?.activeEffects?.echoCancellation,
noiseSuppression: this.localAudioStreamFeatureApi?.activeEffects?.noiseSuppression
}
});
}

async populateAudioEffects() {
const supported = [];

Expand Down Expand Up @@ -164,6 +181,11 @@ export default class AudioEffectsContainer extends React.Component {
noiseSuppression: {
...this.state.noiseSuppression,
noiseSuppressionList
},
activeEffects: {
autoGainControl: this.localAudioStreamFeatureApi?.activeEffects?.autoGainControl,
echoCancellation: this.localAudioStreamFeatureApi?.activeEffects?.echoCancellation,
noiseSuppression: this.localAudioStreamFeatureApi?.activeEffects?.noiseSuppression
}
});
}
Expand Down Expand Up @@ -366,19 +388,19 @@ export default class AudioEffectsContainer extends React.Component {
</div>
</div>
<div className='ms-Grid-row' style={{ marginBottom: '1rem' }}>
{this.localAudioStreamFeatureApi?.activeEffects?.autoGainControl?.length > 0 &&
{this.state.activeEffects.autoGainControl?.length > 0 &&
<div className='ms-Grid-col ms-sm4 ms-md4 ms-lg4'>
{this.localAudioStreamFeatureApi.activeEffects.autoGainControl[0]}
{this.state.activeEffects.autoGainControl[0]}
</div>
}
{this.localAudioStreamFeatureApi?.activeEffects?.echoCancellation?.length > 0 &&
{this.state.activeEffects.echoCancellation?.length > 0 &&
<div className='ms-Grid-col ms-sm4 ms-md4 ms-lg4'>
{this.localAudioStreamFeatureApi.activeEffects.echoCancellation[0]}
</div>
}
{this.localAudioStreamFeatureApi?.activeEffects?.noiseSuppression?.length > 0 &&
{this.state.activeEffects.noiseSuppression?.length > 0 &&
<div className='ms-Grid-col ms-sm4 ms-md4 ms-lg4'>
{this.localAudioStreamFeatureApi.activeEffects.noiseSuppression[0]}
{this.state.activeEffects.noiseSuppression[0]}
</div>
}
</div>
Expand Down
Loading