Lobby call support sample #228

v-kuppu · 2025-07-29T11:01:41Z

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

…cations

…onfimration from client app.

microsoft-github-policy-service · 2025-07-29T11:01:50Z

@v-kuppu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

…ommunication.

v-dharmarajv · 2025-08-12T18:33:33Z

Purpose

...

Does this introduce a breaking change?
[ ] Yes
[ ] No
Pull Request Type

What kind of change does this Pull Request introduce?
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:
How to Test

Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
Test the code

What to Check

Verify that the following are valid

...

Other Information

Add the description for this sample

v-dharmarajv · 2025-08-12T18:34:25Z

LobbyCallSupportSample/LobbyCallSupportSample/Properties/launchSettings.json

@@ -0,0 +1,41 @@
+{


Keep only one profile here

v-dharmarajv · 2025-08-12T18:36:11Z

LobbyCallSupportSample/LobbyCallSupportSample/appsettings.json

+      "Microsoft.AspNetCore": "Warning"
+    }
+  },
+  "AllowedHosts": "*",


lets follow the similar format which we have used in other samples ex.

v-dharmarajv · 2025-08-12T18:39:15Z

LobbyCallSupportSample/LobbyCallSupportSample/readme.md

+
+# Call Automation - Lobby Call Support Sample
+
+In this sample, we cover how you can use Call Automation SDK to support Lobby Call where we join Lobby call users to a target call upon confirmation of admin in the target call.


We can use the below description for the call or add more detailed version of this.

This sample demonstrates how to utilize the Call Automation SDK to implement a Lobby Call scenario. In this setup, users initially join a lobby call and remain on hold until an user in the target call confirms their participation. Once approved, the bot automatically connects the lobby users to the designated target call.

v-dharmarajv · 2025-08-12T18:40:33Z

LobbyCallSupportSample/LobbyCallSupportSample/readme.md

+
+- An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/?WT.mc_id=A261C142F).
+- A deployed Communication Services resource. [Create a Communication Services resource](https://docs.microsoft.com/azure/communication-services/quickstarts/create-communication-resource).
+- A [phone number](https://learn.microsoft.com/en-us/azure/communication-services/quickstarts/telephony/get-phone-number) in your Azure Communication Services resource that can make outbound calls. NB: phone numbers are not available in free subscriptions.


lets not mention this here "NB: phone numbers are not available in free subscriptions." As the phone number availability keeps changing.

v-dharmarajv · 2025-08-12T18:42:07Z

LobbyCallSupportSample/LobbyCallSupportSample/appsettings.json

+  "acsGeneratedIdForLobbyCallReceiver": "<acsGeneratedIdForLobbyCallReceiver>",
+  "acsGeneratedIdForTargetCallReceiver": "<acsGeneratedIdForTargetCallReceiver>",
+  "acsGeneratedIdForTargetCallSender": "<acsGeneratedIdForTargetCallSender>",
+  "socketToken": "<socketToken>"


Is this still required?

Removed socketTocken , but other keys are required.

v-dharmarajv · 2025-08-12T18:51:11Z

LobbyCallSupportSample/LobbyCallSupportSample/readme.md

+- A [phone number](https://learn.microsoft.com/en-us/azure/communication-services/quickstarts/telephony/get-phone-number) in your Azure Communication Services resource that can make outbound calls. NB: phone numbers are not available in free subscriptions.
+- Create Azure AI Multi Service resource. For details, see [Create an Azure AI Multi service](https://learn.microsoft.com/en-us/azure/cognitive-services/cognitive-services-apis-create-account).
+- Create and host a Azure Dev Tunnel. Instructions [here](https://learn.microsoft.com/en-us/azure/developer/dev-tunnels/get-started)
+- A Client application that can make calls to the Azure Communication Services resource. This can be a web client or a mobile client. You can use the [Web Client Quickstart](https://github.com/Azure-Samples/communication-services-javascript-quickstarts/tree/users/v-kuppu/LobbyCallConfirmSample)


Add the details in the decription

v-dharmarajv · 2025-08-12T18:51:42Z

LobbyCallSupportSample/LobbyCallSupportSample/readme.md

+- Create and host a Azure Dev Tunnel. Instructions [here](https://learn.microsoft.com/en-us/azure/developer/dev-tunnels/get-started)
+- A Client application that can make calls to the Azure Communication Services resource. This can be a web client or a mobile client. You can use the [Web Client Quickstart](https://github.com/Azure-Samples/communication-services-javascript-quickstarts/tree/users/v-kuppu/LobbyCallConfirmSample)
+
+## Before running the sample for the first time


These are specific to JS, please update the steps for the dotnet

v-dharmarajv · 2025-08-12T18:52:37Z

LobbyCallSupportSample/LobbyCallSupportSample/readme.md

+   - For more information, see [Create an Azure AI Multi service](https://learn.microsoft.com/en-us/azure/cognitive-services/cognitive-services-apis-create-account).
+3. `callbackUriHost`: Base url of the app. (For local development use dev tunnel url)
+4. `confirmMessageToTargetCall`: Notification message to be played to the target call participants when they are moved from lobby call to target call.
+   - This is used to notify the target call participants that they are being moved from lobby call to target call.


Move these values to program.cs. Lets just keep the settings here (the settings which needs to updated by the user)

Please confirm for callbackUriHost ? I think we can remove only confirmMessageToTargetCall and textToPlayToLobbyUser keys.

v-dharmarajv · 2025-08-12T18:56:39Z

LobbyCallSupportSample/LobbyCallSupportSample/readme.md

+	 "acsGeneratedIdForTargetCallReceiver": "<acsGeneratedIdForTargetCallReceiver>",(Generate Voice Calling Identity in Azure Portal)
+	 "acsGeneratedIdForTargetCallSender": "<acsGeneratedIdForTargetCallSender>",(Generate Voice Calling Identity in Azure Portal)
+	 "socketToken": "<socketToken>"(Token associated with <acsGeneratedIdForTargetCallSender> in Azure Portal)```
+3. Define a websocket in your application(program.cs) to send and receive messages from and to client application(JS Hero App in this case).


provide the websocket url format /ws and also add steps to provide them in the JS UI sample with the link

v-dharmarajv · 2025-08-12T18:57:21Z

LobbyCallSupportSample/LobbyCallSupportSample/readme.md

+5. Enter and validate user token in client app to send calls.
+6. Start call to `<acsGeneratedIdForTargetCallReceiver>`.
+7. Expect Call Connected evennt in /callbacks
+8. Start a call from ACS Test app(angular) to acsGeneratedIdForLobbyCallReceiver


Which application is this?

v-dharmarajv · 2025-08-12T18:58:40Z

LobbyCallSupportSample/LobbyCallSupportSample/readme.md

+11. Once the Target call confirms from client application, Move `<acsGeneratedIdForLobbyCallReceiver>` in the backend sample.
+12. If Target user says no, then no MOVE will be performed.
+13. Ensure MoveParticipantSucceeded event is received in `/callbacks` endpoint.
+14. Check `/Getparticipants` endpoint be called with Target call id, Target call must have the recent lobby user in the call.


we might not ask the user to verify this, instead once the participant moved to target call, print the total participants and user display name

v-kuppu added 4 commits July 21, 2025 22:17

Lobby Call Support Sample - Initial Checkin without client app modifi…

4948bb4

…cations

Lobby Call Support Sample - added support for web socket to recdive c…

a2a36ff

…onfimration from client app.

LobbyCallSupportSample - testing and code tweaks

cec29b7

Lobby Call Support Sample - final checkin

e496346

Updates to Readme.md

d13fb43

huachuandeng approved these changes Jul 30, 2025

View reviewed changes

v-kuppu added 2 commits July 31, 2025 13:46

Lobby Call Support Sample - removed token dependency for web socket c…

6f97862

…ommunication.

Lobby Call Support Sample - moved missed sensitive data to config

f2091aa

v-dharmarajv marked this pull request as ready for review August 12, 2025 18:33

v-dharmarajv reviewed Aug 12, 2025

View reviewed changes

LobbyCallSupportSample/LobbyCallSupportSample/Properties/launchSettings.json

@@ -0,0 +1,41 @@

{

Copy link

Contributor

v-dharmarajv Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep only one profile here

v-dharmarajv reviewed Aug 12, 2025

View reviewed changes


		# Call Automation - Lobby Call Support Sample

		In this sample, we cover how you can use Call Automation SDK to support Lobby Call where we join Lobby call users to a target call upon confirmation of admin in the target call.

Lobby call support sample #228

Are you sure you want to change the base?

Lobby call support sample #228

Uh oh!

Conversation

v-kuppu commented Jul 29, 2025

Purpose

Does this introduce a breaking change?

Pull Request Type

How to Test

What to Check

Other Information

Uh oh!

microsoft-github-policy-service bot commented Jul 29, 2025

Contribution License Agreement

Uh oh!

v-dharmarajv commented Aug 12, 2025

Purpose

Does this introduce a breaking change?

Pull Request Type

How to Test

What to Check

Other Information

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-dharmarajv Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

v-dharmarajv Aug 12, 2025 •

edited

Loading