Skip to content

fix: Text is overlapping in the citation section (Line spacing) #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

Devendra-Microsoft
Copy link
Contributor

@Devendra-Microsoft Devendra-Microsoft commented May 28, 2024

Purpose

Text is overlapping in the citation section.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

1-Type something on chat bot for e.g. "Provide the details of European Equities Fund"
2-Click on references and select "Woodgrove Asset Mana...Management Funds.pdf - Part 81".
3-Find the text overlapping in citation section.

What to Check

In citation section , you will see there is no overlapping text now.

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL250356177% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
278 0 💤 0 ❌ 0 🔥 35.166s ⏱️

@adamdougal
Copy link
Collaborator

@Devendra-Microsoft Thanks for this PR! Do you have any screenshots showing the issue? I can't seem to reproduce it. Thanks

@Devendra-Microsoft
Copy link
Contributor Author

@adamdougal , Please find the screenshot attached here.

4100

Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! Looks good to me!

@adamdougal adamdougal added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit a5ac4a4 May 30, 2024
11 checks passed
@adamdougal adamdougal deleted the psl-bug-4100 branch May 30, 2024 08:13
Copy link

🎉 This PR is included in version 1.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Devendra-Microsoft Devendra-Microsoft restored the psl-bug-4100 branch June 3, 2024 09:04
@Roopan-Microsoft Roopan-Microsoft deleted the psl-bug-4100 branch April 14, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants