Skip to content

fix: Slight pauses while speaking cause reco to halt and start a new phrase. #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2024
Merged

fix: Slight pauses while speaking cause reco to halt and start a new phrase. #982

merged 5 commits into from
Jun 14, 2024

Conversation

Rohini-Microsoft
Copy link
Contributor

Purpose

  • Append text after slight pause in the current sentence
  • Solution added login in chat.tsx file for appending the text and also added functionality when microphone is on the text area is disabled.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Click on microphone and speak something and take a pause and again speak.
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

  • Text should be appending on previous text

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL256756378% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
288 0 💤 0 ❌ 0 🔥 39.611s ⏱️

@adamdougal adamdougal requested a review from superhindupur May 29, 2024 14:57
adamdougal
adamdougal previously approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This worked well for me!

@adamdougal adamdougal enabled auto-merge June 14, 2024 16:30
@adamdougal adamdougal added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit e10a0fa Jun 14, 2024
9 checks passed
@adamdougal adamdougal deleted the PSL-BUG1740 branch June 14, 2024 16:35
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdougal adamdougal adamdougal approved these changes

@Roopan-Microsoft Roopan-Microsoft Awaiting requested review from Roopan-Microsoft Roopan-Microsoft is a code owner

@superhindupur superhindupur Awaiting requested review from superhindupur

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rohini-Microsoft @adamdougal @ross-p-smith