Skip to content

fix: Remove duplicated citation #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 3, 2024
Merged

fix: Remove duplicated citation #980

merged 12 commits into from
Jun 3, 2024

Conversation

Prashant-Microsoft
Copy link
Contributor

@Prashant-Microsoft Prashant-Microsoft commented May 24, 2024

Purpose

Web App: In the reference section we are getting duplicate documents and after fixing this bug will not receive any duplicate documents

Does this introduce a breaking change?

  • Yes
  • No

How to Test

If you type something on chat bot for e.g. "Summarize the Microsoft 10k document in 1 word" then we are getting the duplicates document in the reference section

What to Check

After receiving response from chatbot you can check the reference section and now the duplicate document should disappear

@Prashant-Microsoft Prashant-Microsoft self-assigned this May 24, 2024
@Prashant-Microsoft Prashant-Microsoft changed the title PSL-BUG-1745 Fixed fix: PSL-BUG-1745 Fixed May 24, 2024
Copy link

github-actions bot commented May 27, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL250256177% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
278 0 💤 0 ❌ 0 🔥 34.357s ⏱️

Copy link
Contributor

@Roopan-Microsoft Roopan-Microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the changes.

@ross-p-smith ross-p-smith changed the title fix: PSL-BUG-1745 Fixed fix: Remove duplicated citation May 27, 2024
@ross-p-smith
Copy link
Collaborator

This is related to PSL-BUG-1745

Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to break the parsing and formatting of the citations, see the image below where [doc1] etc is outputted:

image

What it should look like (ideally without the duplicates):

image

@Prashant-Microsoft
Copy link
Contributor Author

This appears to break the parsing and formatting of the citations, see the image below where [doc1] etc is outputted:

image

What it should look like (ideally without the duplicates):

image

Fixed :
image

Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have conflicts unfortunately :(

adamdougal
adamdougal previously approved these changes Jun 3, 2024
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamdougal adamdougal added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit be35879 Jun 3, 2024
9 checks passed
@adamdougal adamdougal deleted the PSL-BUG-1745 branch June 3, 2024 15:13
Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants