Skip to content

feat: Set limit for advanced image processing images #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

cecheta
Copy link
Collaborator

@cecheta cecheta commented May 24, 2024

Required for #750

Purpose

  • Set a limit to the number of images that are passed to the LLM when using advanced image processing. Defaults to 1

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Deploy code, with advanced image processing enabled
  • Upload similar images
  • Make query about images
  • Check number of images passed to LLM

@cecheta cecheta requested review from adamdougal and frtibble May 24, 2024 15:16
Copy link

github-actions bot commented May 24, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   env_helper.py140695%240–242, 261–263
code/backend/batch/utilities/tools
   question_answer_tool.py700100% 
TOTAL250356177% 

Tests Skipped Failures Errors Time
278 0 💤 0 ❌ 0 🔥 35.309s ⏱️

adamdougal
adamdougal previously approved these changes May 24, 2024
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I assume search returns images in order of closest match?

ross-p-smith
ross-p-smith previously approved these changes May 27, 2024
frtibble
frtibble previously approved these changes May 28, 2024
@cecheta cecheta dismissed stale reviews from frtibble, ross-p-smith, and adamdougal via 273b4bf May 28, 2024 08:55
@cecheta
Copy link
Collaborator Author

cecheta commented May 28, 2024

LGTM! I assume search returns images in order of closest match?

Yep, this is from the docs:

If no OrderBy is specified, the default sort order is descending by document match score.

@cecheta cecheta requested review from adamdougal and frtibble May 28, 2024 08:56
@cecheta cecheta added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit f604655 May 28, 2024
11 checks passed
@cecheta cecheta deleted the feat/750/limit branch May 28, 2024 09:05
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants