Skip to content

fix: The Web UX is intentionally not revealing references when clicked to display #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2024

Conversation

Rohini-Microsoft
Copy link
Contributor

@Rohini-Microsoft Rohini-Microsoft commented May 24, 2024

Purpose

The Web UX is intentionally not revealing references when clicked to display

solution: Added logic in Answer.tsx file in useEffect method. Also used useRef hook.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Tested locally by manually asked question in chatbot and will get references. When you got all references then click on the references link.

What to Check

  • .On click of references link then you will see all references.

Copy link

github-actions bot commented May 24, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL250056177% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
277 0 💤 0 ❌ 0 🔥 34.630s ⏱️

@Rohini-Microsoft Rohini-Microsoft changed the title added scroll bar logic for references Fixing bug- 1742 May 24, 2024
@Rohini-Microsoft Rohini-Microsoft changed the title Fixing bug- 1742 fix: A 1742 bug fixed May 24, 2024
@Rohini-Microsoft Rohini-Microsoft changed the title fix: A 1742 bug fixed fix: A 1742 bug fixed. feat: feature branch PSL-BUG-1742 May 24, 2024
@Rohini-Microsoft Rohini-Microsoft changed the title fix: A 1742 bug fixed. feat: feature branch PSL-BUG-1742 fix: A 1742 bug fixed. May 24, 2024
@ross-p-smith
Copy link
Collaborator

@Rohini-Microsoft - The title of this PR will go into the Release Notes. It's great that you are referencing the issue that this fixes - can that be in the Pull Request Description and you add a useful short description of what this PR solves?

e.g. fix: UI not revealing references when clicked

@Rohini-Microsoft Rohini-Microsoft changed the title fix: A 1742 bug fixed. fix: UI not revealing references when clicked May 27, 2024
@Rohini-Microsoft Rohini-Microsoft changed the title fix: UI not revealing references when clicked fix: The Web UX is intentionally not revealing references when clicked to display May 27, 2024
@Rohini-Microsoft Rohini-Microsoft requested review from adamdougal and ross-p-smith and removed request for hunterjam and ross-p-smith May 29, 2024 03:55
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@adamdougal adamdougal added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 70e2a50 May 29, 2024
11 checks passed
@adamdougal adamdougal deleted the PSL-BUG-1742 branch May 29, 2024 14:54
Copy link

🎉 This PR is included in version 1.4.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants