Skip to content

feat: Remove LangChain from question answer tool #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 20, 2024

Conversation

cecheta
Copy link
Collaborator

@cecheta cecheta commented May 17, 2024

Required for #750

Purpose

  • This PR removes LangChain from the Question Anwer Tool
  • Changes the example user/assistant messages to system messages, as from the docs
  • Updates unit and functional tests

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Ask questions to LLM that require Question Answer Tool

Copy link

github-actions bot commented May 17, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   llm_helper.py421173%40–41, 50, 61–62, 73, 86–87, 94, 113, 123
code/backend/batch/utilities/tools
   question_answer_tool.py550100% 
TOTAL242767272% 

Tests Skipped Failures Errors Time
205 0 💤 0 ❌ 0 🔥 12.584s ⏱️

adamdougal
adamdougal previously approved these changes May 17, 2024
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the temperature but looks great!

great

@cecheta cecheta requested a review from adamdougal May 17, 2024 15:15
@cecheta cecheta added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 77b99da May 20, 2024
9 checks passed
@cecheta cecheta deleted the cecheta/remove-langchain-from-question-answer-tool branch May 20, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants