-
Notifications
You must be signed in to change notification settings - Fork 559
feat: Generate and add image captions to search index when image is ingested. #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report •
|
code/backend/batch/utilities/helpers/embedders/push_embedder.py
Outdated
Show resolved
Hide resolved
6125987
to
3c5ff38
Compare
3c5ff38
to
27b35d2
Compare
adamdougal
previously approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code/backend/batch/utilities/helpers/embedders/push_embedder.py
Outdated
Show resolved
Hide resolved
ross-p-smith
previously approved these changes
May 16, 2024
adamdougal
approved these changes
May 16, 2024
ross-p-smith
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749
Purpose
This PR adds the following functionality when an image is uploaded to the knowledge base (when advanced image processing is enabled):
This will allow for improved search on images.
Does this introduce a breaking change?
How to Test
Deploy Chat with your data with Advanced Image Processing enabled.
Upload an image via the admin site.
Then verify on the search index that the
content
andcontent_vector
fields are populated with the appropriate caption and vector embeddings.