Skip to content

fix: Fix computer vision for deployments #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2024
Merged

fix: Fix computer vision for deployments #919

merged 1 commit into from
May 15, 2024

Conversation

cecheta
Copy link
Collaborator

@cecheta cecheta commented May 15, 2024 •
edited
Loading

Purpose

  • This PR handles the conditional creation of the computer vision resource

Does this introduce a breaking change?

  • Yes
  • No

How to Test

Deploy different configurations, with/without computer vision, code/docker

@cecheta cecheta changed the title Fix computer vision for deployments fix: Fix computer vision for deployments May 15, 2024
@cecheta cecheta mentioned this pull request May 15, 2024
Closed
2 tasks
@cecheta cecheta requested a review from adamdougal May 15, 2024 11:42
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL238367371% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
194 0 💤 0 ❌ 0 🔥 12.244s ⏱️

@cecheta cecheta marked this pull request as draft May 15, 2024 12:19
@cecheta cecheta removed the request for review from adamdougal May 15, 2024 12:20
@cecheta
Copy link
Collaborator Author

cecheta commented May 15, 2024

I am going to separate the re-formatting to a new PR

@cecheta cecheta force-pushed the cecheta/computer-vision-error branch from b491e51 to e8b2c51 Compare May 15, 2024 14:05
@cecheta cecheta marked this pull request as ready for review May 15, 2024 14:31
@cecheta cecheta requested a review from adamdougal May 15, 2024 14:34
superhindupur
superhindupur approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@superhindupur superhindupur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the problem was that we were assuming the presence of computer vision parameters?

@cecheta
Copy link
Collaborator Author

cecheta commented May 15, 2024

So the problem was that we were assuming the presence of computer vision parameters?

Correct, but the module was being created conditionally

Error messages weren't clear at all

adamdougal
adamdougal approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I should have tested with advanced image processing disabled :(

@cecheta cecheta added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 548a767 May 15, 2024
17 checks passed
@cecheta cecheta deleted the cecheta/computer-vision-error branch May 15, 2024 14:47
@frtibble frtibble mentioned this pull request May 15, 2024
Closed
liammoat pushed a commit that referenced this pull request May 16, 2024
@cecheta @liammoat
fix: Fix computer vision for deployments (#919)
31bc18b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdougal adamdougal adamdougal approved these changes

@superhindupur superhindupur superhindupur approved these changes

@komalg1 komalg1 komalg1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cecheta @adamdougal @superhindupur @komalg1