Skip to content

fix: error in 'Process and Ingest Web Pages' under 'Add URLs to the Knowledge Base' (CWYD) #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

Priyanka-Microsoft
Copy link
Contributor

Purpose

  • ...
    This pull request introduces several improvements and updates across various files and components, focusing on infrastructure naming conventions, frontend enhancements, backend functionality, and configuration management. The most important changes include the addition of a .dockerignore file, updates to environment variables, enhancements to frontend components, backend validation improvements, and the introduction of standardized abbreviations for resource naming.

Infrastructure Updates:

  • Added infra/abbreviations.json to define standardized abbreviations for Azure resource naming conventions, ensuring consistency across infrastructure.
  • Updated infra/main.bicep to use abbreviations for naming Azure resources, such as psql- for PostgreSQL and oai- for OpenAI services. (Fb0606efL10R10, [1] [2] [3] [4] [5] [6]
  • Removed default value for miName parameter in infra/core/security/managed-identity.bicep to allow more flexible naming.

Backend Enhancements:

  • Improved URL validation in code/backend/pages/01_Ingest_Data.py by adding checks for valid URLs and displaying error messages when none are provided.
  • Refactored reset configuration functionality in code/backend/pages/04_Configuration.py to use a dialog-based approach, simplifying the user experience and improving clarity.

Frontend Enhancements:

  • Introduced tooltips in code/frontend/src/components/ChatHistoryListItemCell/ChatHistoryListItemCell.tsx using Fluent UI's TooltipHost, providing better accessibility and context for truncated chat titles. [1] [2] [3] [4]
  • Mocked TooltipHost in ChatHistoryListItemCell.test.tsx to facilitate testing of tooltip functionality.

Environment Variable Updates:

  • Added AZURE_COSMOSDB_ACCOUNT_KEY to .env.sample to support CosmosDB integration.

General Improvements:

  • Created a .dockerignore file to exclude unnecessary files and directories from Docker builds, improving container efficiency and security.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 69669bb into dev Jun 2, 2025
6 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the bugfix/cwyd-process-ingest-error branch June 2, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants