Skip to content

fix: Updated reset configuration to use dialog instead of popover which now closes on X button click, Submit Button Now Resets Widgets to default values by clearing config #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

Vamshi-Microsoft
Copy link
Contributor

This pull request refactors the reset configuration functionality in code/backend/pages/04_Configuration.py to improve user experience and code clarity. The changes replace the previous popover-based implementation with a dialog-based approach, streamline the reset process, and ensure better state management.

Does this introduce a breaking change?

  • Yes
  • No

…ver, Clear cofig to reset streamlit widgets to default values.
@Vamshi-Microsoft
Copy link
Contributor Author

@Vamshi-Microsoft please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree company="Persistent"

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@Vamshi-Microsoft
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Persistent"

@Vamshi-Microsoft Vamshi-Microsoft changed the title Updated reset configuration to use dialog instead of popover which now closes on X button click, Submit Button Now Resets Widgets to default values by clearing config Fix: Updated reset configuration to use dialog instead of popover which now closes on X button click, Submit Button Now Resets Widgets to default values by clearing config May 9, 2025
@Vamshi-Microsoft Vamshi-Microsoft changed the title Fix: Updated reset configuration to use dialog instead of popover which now closes on X button click, Submit Button Now Resets Widgets to default values by clearing config fix: Updated reset configuration to use dialog instead of popover which now closes on X button click, Submit Button Now Resets Widgets to default values by clearing config May 9, 2025
@Avijit-Microsoft Avijit-Microsoft merged commit cea820d into dev May 9, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants