Skip to content

fix: quota check script with dynamic region handling #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Priyanka-Microsoft
Copy link
Contributor

@Priyanka-Microsoft Priyanka-Microsoft commented Feb 26, 2025

Add the variable AZURE_REGIONS with the value: northcentralus, eastus2, westus.

Purpose

  • ...
    This pull request includes changes to the CI workflow and the checkquota.sh script to improve the handling of Azure regions and environment variables. The most important changes are as follows:

CI Workflow Updates:

  • .github/workflows/ci.yml: Updated the GPT_MIN_CAPACITY environment variable to a lower value and added a new environment variable AZURE_REGIONS to the workflow.

Script Enhancements:

  • scripts/checkquota.sh: Modified the script to read the AZURE_REGIONS environment variable and split it into an array of regions using the IFS and read commands.
  • scripts/checkquota.sh: Updated the environment variable validation to include a check for the REGIONS variable.

Does this introduce a breaking change?

No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 6fe96c3 Feb 26, 2025
9 checks passed
@Priyanka-Microsoft Priyanka-Microsoft deleted the fix/dynamic-region-list branch April 3, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants