Skip to content

feat: json document processor #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

Conversation

cristofima
Copy link
Contributor

Purpose

  • Add the ability to upload JSON files and process them

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code

Go to the Admin site. From Ingest Data upload a JSON file
Once the file is processed, go to Explore Data the see the chunks

What to Check

Verify that the following are valid

ingest open api

Check how the code generated the chunks for the JSON file.

open api extracted

Other Information

Try testing with OpenAPI JSON files, but any JSON file is ok.

@cristofima
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Roopan-Microsoft
Copy link
Contributor

Thanks @cristofima for your contribution, we will validate from our end!

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/document_chunking
   chunking_strategy.py16193%26
   json.py211242%11, 16, 19–22, 24–27, 36–37
   strategies.py18572%16–19, 21
code/backend/batch/utilities/helpers/config
   config_helper.py181298%91, 94
TOTAL384487177% 

Tests Skipped Failures Errors Time
395 0 💤 4 ❌ 0 🔥 54.032s ⏱️

@Roopan-Microsoft Roopan-Microsoft changed the base branch from dev to main April 15, 2025 10:50
@Roopan-Microsoft Roopan-Microsoft changed the base branch from main to dev April 15, 2025 10:50
@Roopan-Microsoft Roopan-Microsoft merged commit dc763c2 into Azure-Samples:dev Apr 16, 2025
6 checks passed
@Roopan-Microsoft
Copy link
Contributor

@cristofima - Apologies for the delay, we have merged your PR and validating your changes in out intermediate branch. Will keep you posted once it is merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants