-
Notifications
You must be signed in to change notification settings - Fork 559
ci: update docker registry logic for main, dev, and demo branches #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… demo it is updating in one registry
Roopan-Microsoft
requested changes
Feb 7, 2025
Roopan-Microsoft
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Registry Logic: The workflow now dynamically assigns the correct container registry based on the branch (main, dev, demo).
For main, the workflow pushes to two registries.
For dev and demo, it pushes to one registry only.
https://dev.azure.com/CSACTOSOL/CSA%20Solutioning/_workitems/edit/13464/
Purpose
This pull request includes changes to the Docker build and push workflows, as well as updates to the infrastructure configuration. The main focus is on separating the Docker registries and usernames for different branches and updating the registry name in the infrastructure files.
Changes to Docker build and push workflows:
.github/workflows/build-docker-images.yml
: Updated the registry and username parameters to separate the old and new values for different branches..github/workflows/build-docker.yml
: Added new inputs fornew_registry
andnew_username
, and modified the Docker login steps to handle logins for both the old and new registries based on the branch. [1] [2].github/workflows/build-docker.yml
: Added a new secretDOCKER_PASSWORD_SEC
and updated the build steps to push Docker images to both the old and new registries. [1] [2]Updates to infrastructure configuration:
infra/main.bicep
: Changed theregistryName
variable to use the new registry namecwydcontainerreg
.infra/main.json
: Updated theregistryName
parameter tocwydcontainerreg
.Does this introduce a breaking change?
No
How to Test
What to Check
Verify that the following are valid
Other Information