Skip to content

ci: update docker registry logic for main, dev, and demo branches #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 7, 2025

Conversation

Priyanka-Microsoft
Copy link
Contributor

@Priyanka-Microsoft Priyanka-Microsoft commented Feb 6, 2025

Updated Registry Logic: The workflow now dynamically assigns the correct container registry based on the branch (main, dev, demo).
For main, the workflow pushes to two registries.
For dev and demo, it pushes to one registry only.

https://dev.azure.com/CSACTOSOL/CSA%20Solutioning/_workitems/edit/13464/

Purpose

  • ...
    This pull request includes changes to the Docker build and push workflows, as well as updates to the infrastructure configuration. The main focus is on separating the Docker registries and usernames for different branches and updating the registry name in the infrastructure files.

Changes to Docker build and push workflows:

Updates to infrastructure configuration:

  • infra/main.bicep: Changed the registryName variable to use the new registry name cwydcontainerreg.
  • infra/main.json: Updated the registryName parameter to cwydcontainerreg.

Does this introduce a breaking change?

No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Priyanka-Microsoft Priyanka-Microsoft changed the title Update Docker Registry Logic for Main, Dev, and Demo Branches update docker registry logic for main, dev, and demo branches Feb 6, 2025
@Priyanka-Microsoft Priyanka-Microsoft changed the title update docker registry logic for main, dev, and demo branches ci: update docker registry logic for main, dev, and demo branches Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL381985777% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
395 0 💤 0 ❌ 0 🔥 56.153s ⏱️

@Roopan-Microsoft Roopan-Microsoft merged commit 7025c6e into dev Feb 7, 2025
6 checks passed
@Priyanka-Microsoft Priyanka-Microsoft deleted the update-cwyd-container-registry-name branch April 3, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants