Skip to content

fix: Psl container fix #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
249e8b9
Merge remote-tracking branch 'origin/main' into dev
AjitPadhi-Microsoft Nov 27, 2024
cf413c2
updated workflow
AjitPadhi-Microsoft Nov 27, 2024
5390939
Merge branch 'dev' into psl-container-fix
Roopan-Microsoft Nov 27, 2024
b8eecde
added echo in workflow
AjitPadhi-Microsoft Nov 27, 2024
04a621d
merged with dev
AjitPadhi-Microsoft Nov 27, 2024
db4732f
Docker yml updated checkout code
Roopan-Microsoft Nov 27, 2024
d7e7b8b
Merge branch 'psl-container-fix' of https://github.com/Azure-Samples/…
Roopan-Microsoft Nov 27, 2024
70c95b6
Merge branch 'dev' into psl-container-fix
Roopan-Microsoft Nov 27, 2024
d507ba5
added checkout in docker images yml file
Roopan-Microsoft Nov 27, 2024
c815e80
updated workflow
AjitPadhi-Microsoft Nov 27, 2024
07f5f46
Reverted the head branch code from yml file
Roopan-Microsoft Nov 27, 2024
dc7d85e
Merge branch 'psl-container-fix' of https://github.com/Azure-Samples/…
Roopan-Microsoft Nov 27, 2024
b8e3e32
fixed workflow
AjitPadhi-Microsoft Nov 27, 2024
d827339
merged with dev
AjitPadhi-Microsoft Nov 27, 2024
8bdabc4
updated secrets as explicity passing
Roopan-Microsoft Nov 27, 2024
856578f
secrets explicit passing in yml file
Roopan-Microsoft Nov 27, 2024
0228f72
build docker image supdated
Roopan-Microsoft Nov 27, 2024
a12648a
updated workflow
AjitPadhi-Microsoft Nov 27, 2024
038d46f
merged with main
AjitPadhi-Microsoft Nov 27, 2024
d600af2
changed branch head
Roopan-Microsoft Nov 27, 2024
fd94e3c
Merge branch 'dev' into psl-container-fix
Roopan-Microsoft Nov 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions .github/workflows/build-docker-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ on:

jobs:
docker-build:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success' }}
strategy:
matrix:
Expand All @@ -26,12 +27,21 @@ jobs:
dockerfile: docker/Backend.Dockerfile
- app_name: rag-webapp
dockerfile: docker/Frontend.Dockerfile
uses: ./.github/workflows/build-docker.yml
with:
registry: ${{ github.event.workflow_run.head_branch == 'main' && 'fruoccopublic.azurecr.io' || 'cwydcontainerreg.azurecr.io'}}
username: ${{ github.event.workflow_run.head_branch == 'main' && 'fruoccopublic' || 'cwydcontainerreg'}}
app_name: ${{ matrix.app_name }}
dockerfile: ${{ matrix.dockerfile }}
branch: ${{ github.event.workflow_run.head_branch }}
push: ${{ github.event_name == 'workflow_run' && (github.event.workflow_run.head_branch == 'main' || github.event.workflow_run.head_branch == 'dev' || github.event.workflow_run.head_branch == 'demo') }}
secrets: inherit
steps:
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ github.event.workflow_run.head_branch }}

- name: Build Docker Image
uses: ./.github/workflows/build-docker.yml
with:
registry: ${{ github.event.workflow_run.head_branch == 'main' && 'fruoccopublic.azurecr.io' || 'cwydcontainerreg.azurecr.io'}}
username: ${{ github.event.workflow_run.head_branch == 'main' && 'fruoccopublic' || 'cwydcontainerreg'}}
app_name: ${{ matrix.app_name }}
dockerfile: ${{ matrix.dockerfile }}
branch: ${{ github.event.workflow_run.head_branch }}
push: ${{ github.event_name == 'workflow_run' && (github.event.workflow_run.head_branch == 'main' || github.event.workflow_run.head_branch == 'dev' || github.event.workflow_run.head_branch == 'demo') }}
env:
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
DEV_DOCKER_PASSWORD: ${{ secrets.DEV_DOCKER_PASSWORD }}
11 changes: 3 additions & 8 deletions .github/workflows/build-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ on:
push:
required: true
type: boolean
secrets:
DOCKER_PASSWORD:
required: false
DEV_DOCKER_PASSWORD:
required: false

jobs:
docker-build:
Expand All @@ -39,23 +34,23 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ github.event.workflow_run.head_branch }}
ref: ${{ inputs.branch }}

- name: Docker Login
if: ${{ inputs.push == true && inputs.branch == 'main' }}
uses: docker/login-action@v3
with:
registry: ${{ inputs.registry }}
username: ${{ inputs.username }}
password: ${{ secrets.DOCKER_PASSWORD }}
password: ${{ env.DOCKER_PASSWORD }}

- name: Dev Docker Login
if: ${{ inputs.push == true && (inputs.branch == 'dev' || inputs.branch == 'demo') }}
uses: docker/login-action@v3
with:
registry: ${{ inputs.registry }}
username: ${{ inputs.username }}
password: ${{ secrets.DEV_DOCKER_PASSWORD }}
password: ${{ env.DEV_DOCKER_PASSWORD }}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Expand Down
Loading