Skip to content

fix: Auth type set default to rbac and removed resource group from bicep #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix: Auth type set default to rbac and removed resource group from bicep #1538

merged 3 commits into from
Dec 3, 2024

Conversation

Roopan-Microsoft
Copy link
Contributor

Purpose

  • Auth type set default to RBAC
  • Reverted Resource group scope from make file and yml files

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL310991570% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
301 0 💤 0 ❌ 0 🔥 59.492s ⏱️

ross-p-smith
ross-p-smith reviewed Nov 28, 2024
View reviewed changes
@Roopan-Microsoft Roopan-Microsoft added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit d56f098 Dec 3, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Roopan-Microsoft Roopan-Microsoft deleted the psl-auth-default-update branch April 3, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross-p-smith ross-p-smith ross-p-smith left review comments

@Prajwal-Microsoft Prajwal-Microsoft Prajwal-Microsoft approved these changes

@Avijit-Microsoft Avijit-Microsoft Awaiting requested review from Avijit-Microsoft Avijit-Microsoft is a code owner

@Fr4nc3 Fr4nc3 Awaiting requested review from Fr4nc3 Fr4nc3 is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roopan-Microsoft @ross-p-smith @Prajwal-Microsoft