Skip to content

fix: [Bug-4717] reverted all 200% zoom changes #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Conversation

Rohini-Microsoft
Copy link
Contributor

Purpose

Revert changes for Resize of the content without overlap.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

1. High contrast modes
Open CWYD URL.
Go to system setting ->Accessibility->Contrast themes->select aquatic in drop down-> apply.
Go to CWYD URL, you can find the screen, does not have border, so there is no separation between citation panel and other section.

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Please find attached screenshot for reference

![image](https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/assets/168007985/c8d00492-31e0-4e55-867c-98d907810c7f)

![image](https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/assets/168007985/a356e0aa-7d11-4f28-89c1-9f619a029524)

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL257957377% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
288 0 💤 0 ❌ 0 🔥 37.384s ⏱️

@Rohini-Microsoft Rohini-Microsoft changed the title Psl bug 4717 fix: [Bug-4717] reverted all 200% zoom changes Jun 21, 2024
@adamdougal
Copy link
Collaborator

Heya, why is this being reverted? I see you've said it's out of scope, but this seems to work as intended.

@Roopan-Microsoft
Copy link
Contributor

Roopan-Microsoft commented Jun 24, 2024

Heya, why is this being reverted? I see you've said it's out of scope, but this seems to work as intended.

Hi @adamdougal ,

We have provided the fix for 200% zoom in the previous PR and seems to be not completely fixed and bug got re-open. But later we just identified that we are supporting only till 125% as Bob confirmed. So we planned to remove the additional code related to 200% which added by PSL team.

@adamdougal adamdougal added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 7989689 Jun 24, 2024
9 of 10 checks passed
@adamdougal adamdougal deleted the PSL-BUG-4717 branch June 24, 2024 08:08
Copy link

🎉 This PR is included in version 1.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants