Skip to content

fix: font size changes reverted and removed extra padding #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

Rohini-Microsoft
Copy link
Contributor

Purpose

Revert the font size changes and removed extra padding

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
    open cwyd chatbot page and check the font size and spacing

image

@Rohini-Microsoft Rohini-Microsoft changed the title fix : font size changes reverted and removed extra padding fix: font size changes reverted and removed extra padding Jun 19, 2024
Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL257757377% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
288 0 💤 0 ❌ 0 🔥 37.912s ⏱️

@adamdougal
Copy link
Collaborator

Heya! Can you explain why this change is required? Thanks

@adamdougal adamdougal changed the title fix: font size changes reverted and removed extra padding fix: font size changes reverted and removed extra padding Jun 20, 2024
@Roopan-Microsoft
Copy link
Contributor

Heya! Can you explain why this change is required? Thanks

Hey Adam, During the accessibility issue fix we observed that look and feel for the landing page and text size is got impacted. Refer the below screen.
So, We have fixed that now and raised the PR for the same.
image

@adamdougal adamdougal added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 7933686 Jun 20, 2024
9 of 11 checks passed
@adamdougal adamdougal deleted the PSL-BUG-4717 branch June 20, 2024 08:34
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants