Skip to content

fix: Login to Azure in post provision step if not already #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ross-p-smith
Copy link
Collaborator

Relates to #406

If you run azd auth login from your devcontainer, you may not have ran az login which means that during the Post Provision hook, the pfazure command can fail

How to Test

Dont login to Azure using az login
run azd up with PromptFlow enabled

@ross-p-smith ross-p-smith requested a review from adamdougal June 4, 2024 21:48
Copy link

github-actions bot commented Jun 4, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL250256177% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
278 0 💤 0 ❌ 0 🔥 34.225s ⏱️

Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ross-p-smith ross-p-smith added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 1b305b8 Jun 5, 2024
9 checks passed
@ross-p-smith ross-p-smith deleted the ross/create-prompt-flow branch June 5, 2024 08:15
Copy link

github-actions bot commented Jun 5, 2024

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants