Skip to content

fix: The Web UX is intentionally not revealing references when clicked to display #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 31, 2024
Merged

fix: The Web UX is intentionally not revealing references when clicked to display #1008

merged 5 commits into from
May 31, 2024

Conversation

Rohini-Microsoft
Copy link
Contributor

Purpose

The Web UX is intentionally not revealing references when clicked to display

solution: Added logic in Answer.tsx file in useEffect method. Also used useRef hook.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Tested locally by manually asked question in chatbot and will get references. When you got all references then click on the references link.

What to Check

  • .On click of references link then you will see all references.

@Rohini-Microsoft Rohini-Microsoft changed the title Psl bug 1742 fix: The Web UX is intentionally not revealing references when clicked to display May 31, 2024
@github-actions GitHub Actions
Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL250256177% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
278 0 💤 0 ❌ 0 🔥 35.425s ⏱️

adamdougal
adamdougal approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@adamdougal adamdougal added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 8a56849 May 31, 2024
10 checks passed
@adamdougal adamdougal deleted the PSL-BUG-1742 branch May 31, 2024 08:54
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.4.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdougal adamdougal adamdougal approved these changes

@Roopan-Microsoft Roopan-Microsoft Awaiting requested review from Roopan-Microsoft Roopan-Microsoft is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rohini-Microsoft @adamdougal @gaurarpit