Skip to content

Readme update to simplify azd deployment #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 3, 2024

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jul 2, 2024

Purpose

This is mostly a readme change to simplify the steps to deploy using AZD and reduce dependencies.

Additionally a small section is added to show how to run the apps locally (with remote AI resources).

Last, a few changes to the AZD bicep files were made to improve least permission grant in RBAC for each resource.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Follow the readme

What to Check

Verify that the following are valid

  • Steps are valid
  • App deploys and runs

paulyuk added 2 commits July 1, 2024 23:20
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 2, 2024

/assign @eamonoreilly

paulyuk added 2 commits July 2, 2024 00:07
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 2, 2024

Note this issue is getting in the way of clean checks and is independent of this PR:
#10

@eamonoreilly

Signed-off-by: paulyuk <paulyuk@microsoft.com>
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 2, 2024

@eamonoreilly note a few issues/discrepancies with app settings made by Bicep vs. what's documented for AZD. Key names for things like CHAT_MODEL_DEPLOYMENT_NAME do not match. Also the value for OpenAiStorageConnection is set to a full connection string secret, and I think we want it instead to be a OpenAiStorageConnection__accountName.

Would like to consult quickly on what we standardize on.

paulyuk added 6 commits July 2, 2024 11:55
Signed-off-by: paulyuk <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
… and Parameters completely

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 3, 2024

All manual tests pass. Readme updated.

Ready to merge. @eamonoreilly

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@eamonoreilly eamonoreilly merged commit 8d75b64 into Azure-Samples:main Jul 3, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants