Fix false positive on versions not equal to 4 #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version check was quite primitive, checking the jar name and extracting the name from that. This made it quite unreliable, and disabled the plugin for users with their own `axon-*` module (#327). The version check has now been changed. JARs found to contain the name axon will now be checked its META-INF for it's groupId and artifactID, and only be disabled/detected if it is the correct group. Resolves #327
CodeDrivenMitch
requested review from
abuijze,
smcvb and
MateuszNaKodach
and removed request for
a team
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version check was quite primitive, checking the jar name and extracting the name from that. This made it quite unreliable, and disabled the plugin for users with their own
axon-*module (#327).The version check has now been changed. JARs found to contain the name axon will now be checked its META-INF for it's groupId and artifactID, and only be disabled/detected if it is the correct group.
Resolves #327