Fix deterministic and stochastic tournament tests, improve test structure, and update documentation/configuration #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed TestOpponent class to no longer use __init__ constructor - This fixes the PytestCollectionWarning in axelrod/tests/strategies/test_player.py:353 - This modification allows the test to run without issues. See also: #1440
…dGamePlayer class to MakesUseOfLengthAndGamePlayer in axelrod/tests/unit/test_makes_use_of.py to resolve PytestCollectionWarning.
- Fixed 'TestOpponent' import error in 'test_sequence_player.py'. - Refactored test classes with '__init__' constructors to avoid PytestCollectionWarning. - Addressed UserWarnings in 'test_memoryone.py' and 'test_memorytwo.py' related to default player settings. - Handled seed reproducibility warning in 'test_player.py' to ensure deterministic test results. - Investigated RuntimeWarning in 'test_zero_determinant.py' related to invalid division. - Optimized test execution time by running tests in parallel using pytest-xdist. - Addressed minor warnings related to test strategies and examples.
|
Are you using AI to generate these / are you a bot? |
|
I am not a bot, but I do use AI tools to support my work. I have manually
verified and tested my code: my version achieves 100% coverage, with all
tests passing except for one expected xfailed and six skipped. If you have
any concerns or feedback, I’m happy to discuss further.
Il mar 7 gen 2025, 17:00 Marc ***@***.***> ha scritto:
… Are you using AI to generate these / are you a bot?
—
Reply to this email directly, view it on GitHub
<#1462 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFMMLP7GY7DSC3OSDKIBKZ32JP23PAVCNFSM6AAAAABUXLHXLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVGY2TKMRUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I wanted to explain the context of my pull request. While solving some
problems on LeetCode, I stumbled upon your open-source project and decided
to give it a try for fun. After downloading it, I tested it on my machine
with Python 3.13, and I noticed some issues. Following your guidelines, I
made some fixes on my branch to address these problems.
It was a fun exercise for me, and I just wanted to share my work. I
understand these might be minor changes, and I hope they don’t cause any
issues. All the code is my own, though I did use my AI assistant to help
with some commands.
Il mar 7 gen 2025, 17:14 Mik Grimaldi ***@***.***> ha scritto:
… I am not a bot, but I do use AI tools to support my work. I have manually
verified and tested my code: my version achieves 100% coverage, with all
tests passing except for one expected xfailed and six skipped. If you have
any concerns or feedback, I’m happy to discuss further.
Il mar 7 gen 2025, 17:00 Marc ***@***.***> ha scritto:
> Are you using AI to generate these / are you a bot?
>
> —
> Reply to this email directly, view it on GitHub
> <#1462 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BFMMLP7GY7DSC3OSDKIBKZ32JP23PAVCNFSM6AAAAABUXLHXLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVGY2TKMRUGM>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
Looking at the commits, you’ll see there’s nothing major. I mainly updated
some outdated parts of the code that seemed quite old, as they were based
on Python 3.11 or 3.12. I also added the xlist library so that Tox could
run more efficiently on my 8-core machine. That’s pretty much all I
did—just some adjustments to make it work better on my setup.
Thx for your time
Il mar 7 gen 2025, 17:49 Mik Grimaldi ***@***.***> ha scritto:
… I wanted to explain the context of my pull request. While solving some
problems on LeetCode, I stumbled upon your open-source project and decided
to give it a try for fun. After downloading it, I tested it on my machine
with Python 3.13, and I noticed some issues. Following your guidelines, I
made some fixes on my branch to address these problems.
It was a fun exercise for me, and I just wanted to share my work. I
understand these might be minor changes, and I hope they don’t cause any
issues. All the code is my own, though I did use my AI assistant to help
with some commands.
Il mar 7 gen 2025, 17:14 Mik Grimaldi ***@***.***> ha scritto:
> I am not a bot, but I do use AI tools to support my work. I have manually
> verified and tested my code: my version achieves 100% coverage, with all
> tests passing except for one expected xfailed and six skipped. If you have
> any concerns or feedback, I’m happy to discuss further.
>
> Il mar 7 gen 2025, 17:00 Marc ***@***.***> ha scritto:
>
>> Are you using AI to generate these / are you a bot?
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#1462 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/BFMMLP7GY7DSC3OSDKIBKZ32JP23PAVCNFSM6AAAAABUXLHXLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVGY2TKMRUGM>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses multiple improvements and fixes across the project:
Fixes:
test_tournament.py:OpponentTestto use a staticstrategymethod.test_makes_use_of.pyandtest_property.py.pytest-xdist.max_examplesin Hypothesis-based tests to improve efficiency.Makefileto handle warnings without failing.tox.iniandrequirements.txt.Impact:
Please review the changes and provide feedback. Thank you!