Skip to content

Update trigger with topics #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Update trigger with topics #99

merged 2 commits into from
Jan 16, 2025

Conversation

v9n
Copy link
Member

@v9n v9n commented Jan 15, 2025

Fix #94

Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

edges := []*avsproto.TaskEdge{
&avsproto.TaskEdge{
Id: "e1",
Source: "__TRIGGER__",
Source: trigger.Id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reminder to update the tests/templates of sdk-js to test the real id instead of "TRIGGER".

@v9n v9n merged commit b27563e into main Jan 16, 2025
4 checks passed
@v9n v9n deleted the update-trigger-with-topics branch January 16, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the protobuf to change expression to topics
2 participants