Skip to content

Renovate EventTrigger—add metadata, applyToFields, and change output to Value type #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/run-test-on-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ jobs:
BASE_SEPOLIA_RPC_URL: "${{ secrets.BASE_SEPOLIA_RPC_URL }}"
BASE_SEPOLIA_BUNDLER_RPC: "${{ secrets.BASE_SEPOLIA_BUNDLER_RPC }}"
CONTROLLER_PRIVATE_KEY: "${{ secrets.CONTROLLER_PRIVATE_KEY }}"
TENDERLY_API_KEY: "${{ secrets.TENDERLY_API_KEY }}"

run: |
cd ./${{ matrix.test }}
Expand Down
25 changes: 22 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ tidy:
go fmt ./...
go mod tidy -v

## audit: run quality control checks
## audit: run quality control checks (excluding long-running integration tests)
.PHONY: audit
audit:
go mod verify
Expand All @@ -39,15 +39,15 @@ audit:
go test -race -buildvcs -vet=off ./...


## test: run all tests with proper environment
## test: run all tests excluding long-running integration tests
.PHONY: test
test:
go clean -cache
go mod tidy
go build ./...
go test -v -race -buildvcs ./...

## test/cover: run all tests and display coverage with proper environment
## test/cover: run all tests and display coverage excluding long-running integration tests
.PHONY: test/cover
test/cover:
go clean -cache
Expand All @@ -61,6 +61,25 @@ test/cover:
test/quick:
go test -v ./...

## test/integration: run long-running integration tests (usually failing, for debugging only)
.PHONY: test/integration
test/integration:
@echo "⚠️ Running long-running integration tests that often fail..."
@echo "⚠️ These are excluded from regular test runs and are for debugging purposes only"
go clean -cache
go mod tidy
go build ./...
go test -v -race -buildvcs -tags=integration ./integration_test/

## test/all: run all tests including integration tests (not recommended for CI)
.PHONY: test/all
test/all:
@echo "⚠️ Running ALL tests including long-running integration tests..."
go clean -cache
go mod tidy
go build ./...
go test -v -race -buildvcs -tags=integration ./...

## test/package: run tests for a specific package (usage: make test/package PKG=./core/taskengine)
.PHONY: test/package
test/package:
Expand Down
2 changes: 1 addition & 1 deletion aggregator/rpc_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (r *RpcServer) GetNonce(ctx context.Context, payload *avsproto.NonceRequest

nonce, err := aa.GetNonce(r.smartWalletRpc, ownerAddress, big.NewInt(0))
if err != nil {
return nil, status.Errorf(codes.Code(avsproto.Error_SmartWalletRpcError), taskengine.NonceFetchingError)
return nil, status.Errorf(codes.Code(avsproto.ErrorCode_SMART_WALLET_RPC_ERROR), taskengine.NonceFetchingError)
}

return &avsproto.NonceResp{
Expand Down
Loading
Loading