Skip to content

Add test of the apContext.configVars.sendgrid_key for EmailNode #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

chrisli30
Copy link
Member

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two new test functions to validate that global secrets – in particular, sendgrid_key – are properly substituted in REST API calls.

  • Adds TestRestRequestSendGridGlobalSecret to verify the SendGrid global secret substitution and response structure
  • Adds TestRestRequestArbitraryGlobalSecret to demonstrate dynamic substitution of any secret name
  • Updates RestProcessor documentation in vm_runner_rest.go to explain the usage of global secrets

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/taskengine/vm_runner_rest_test.go Adds test functions for verifying secret substitution in REST calls
core/taskengine/vm_runner_rest.go Adds documentation comments to RestProcessor
Comments suppressed due to low confidence (1)

core/taskengine/vm_runner_rest.go:1

  • The function name 'NewRestProrcessor' appears to be misspelled; consider renaming it to 'NewRestProcessor' for clarity.
package taskengine

@chrisli30 chrisli30 merged commit fc88994 into staging Jun 20, 2025
16 checks passed
@chrisli30 chrisli30 deleted the chris-add_sendgrid branch June 20, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant