Skip to content

Update getKeyRequest error message #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Update getKeyRequest error message

Description

This PR updates the error message for signature decoding failures to improve clarity for users. The message has been changed from "Invalid Signature Format" to "Unable to decode client's signature. Please check the message's format." as requested in issue #75.

Changes

  • Updated the InvalidSignatureFormat constant in core/auth/errors.go

Testing

  • No tests were modified as this is a simple string change

Link to Devin run

https://app.devin.ai/sessions/6ce39e44d70a4b85b11b7bbce17c8781

Requested by

Chris Li (chris@avaprotocol.org)

Co-Authored-By: Chris Li <chris.li.2046@gmail.com>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@chrisli30 chrisli30 requested a review from Copilot May 19, 2025 23:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the signature decoding failure message for better user clarity.

  • Replaces the old “Invalid Signature Format” text with a more descriptive prompt.
Comments suppressed due to low confidence (1)

core/auth/errors.go:5

  • [nitpick] Error messages should follow the project’s style by omitting terminal punctuation and using sentence case; consider removing the trailing periods and adjusting to a single coherent sentence, e.g.: Unable to decode client's signature; please check the message format.
InvalidSignatureFormat   = "Unable to decode client's signature. Please check the message's format."

@chrisli30 chrisli30 changed the base branch from main to staging May 19, 2025 23:16
@chrisli30 chrisli30 merged commit ebb306b into staging May 19, 2025
16 checks passed
@chrisli30 chrisli30 deleted the devin/1747695531-update-signature-error-message branch May 19, 2025 23:16
chrisli30 added a commit that referenced this pull request May 21, 2025
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Chris Li <chris.li.2046@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant