Fix lint errors: range over integer, missing types in composite liter…

[chrisli30]

…als, unused variable, and unused parameter (#233)

[Copilot]

Pull Request Overview

This PR fixes several lint errors across the codebase by removing redundant code, updating struct literals, and adjusting formatting and iteration patterns. Key changes include:

• Removal of unnecessary return statements in functions that return an error.
• Updating anonymous struct literals to use explicit field names.
• Adjustments to formatting, import aliases, and loop constructs to conform to linting rules.

Reviewed Changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
core/taskengine/trigger/common.go	Removed extraneous return statement in retryConnectToRpc
core/taskengine/trigger/block.go	Deleted an unnecessary blank line in block trigger loop
core/taskengine/stats_test.go	Updated struct literal to use field name "Task:" consistently
core/taskengine/secret_test.go	Updated struct literal to use field name "Task:" consistently
core/taskengine/macros/exp.go	Changed resty import alias for consistency
core/taskengine/macros/contract.go	Added explicit alias for the ethereum import
core/taskengine/executor_test.go	Updated struct literal usage in task tests
core/taskengine/engine_test.go	Changed for-loop iteration syntax to a conventional for loop
core/taskengine/engine.go	Removed redundant return statement; reformatted logger usage
core/taskengine/cursor.go	Changed import alias for ulid
core/auth/server.go	Cleaned up extra blank line
aggregator/rpc_server.go	Updated panic message text to use consistent lower-case phrasing
aggregator/repl.go	Removed extra blank lines and updated the timestamp format for backups
aggregator/key.go	Updated struct literal to include a named field for registered claims
.pre-commit-config.yaml	Modified go fmt entry to remove the -w flag
.golangci.yml	Temporarily disabled typecheck due to import resolution issues
.github/workflows/run-test-on-pr.yml	Skipped lint for a specific PR and updated Go version used in workflows

Comments suppressed due to low confidence (4)

core/taskengine/trigger/common.go:50

• Removal of the 'return nil' statement in retryConnectToRpc() may leave the function without an explicit error return. Please verify that the function's contract is maintained and it returns an error as expected.

return nil

core/taskengine/engine.go:101

• The removal of 'return nil' in retryWsRpc() could affect the function's behavior since it has an error return type. Ensure that the function still returns a proper error or revise its signature accordingly.

return nil

aggregator/repl.go:158

• [nitpick] The updated timestamp format improves clarity, but please confirm that it is consistent with other backup naming conventions used throughout the codebase.

timestamp := time.Now().Format("20060102-150405") // YYYYMMDD-HHMMSS

.pre-commit-config.yaml:6

• [nitpick] Changing the go fmt entry from using the -w flag to plain formatting may affect auto-formatting in your pre-commit hooks. Ensure that this change aligns with your repository’s desired formatting workflow.

entry: go fmt ./...