Re-organize workflows and releasing process #202
Conversation
|
|
||
| # Due to EigenSDK package differences on Ethereum mainnet, | ||
| # this workflow ensures the mainnet branch stays in sync with main | ||
| # while maintaining its own Docker image tag. |
There was a problem hiding this comment.
The original mainnet.yml is deleted and triggered manually by update-docker-mainnet.yml on-demand instead.
|
|
||
| - name: Run semantic versioning and release | ||
| id: semantic-release | ||
| uses: go-semantic-release/action@v1 |
There was a problem hiding this comment.
The go-semantic-release library will replace the existing tagging process offered by the Go native method. It enforces version format, auto-bump versions, and create a release.
The scripts are not tested yet, but if the plan in RELEASE.md makes sense I will test and finalize them.
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - staging |
There was a problem hiding this comment.
The staging Docker image is updated after each PR merge. This branch serves as a caching and testing pool before changes are merged into main, which basically means the code goes live.
| uses: docker/build-push-action@v6 | ||
| with: | ||
| build-args: | | ||
| RELEASE_TAG=${{ inputs.tag || github.sha || github.head_ref || github.ref_name }} | ||
| RELEASE_TAG=staging-${{ github.sha }} |
There was a problem hiding this comment.
i thinkwe should keep:
- branch-name: so we can pin toward
avaprotocol/avs-dev:test-my-new-featureinstead of manuallly update your code everytime to point to new sha - really userful to have the abilitty to trigger build with dispatch and set the tag yourself.
| tags: | | ||
| avaprotocol/ap-avs:mainnet | ||
| build-args: | | ||
| RELEASE_TAG=mainnet-${{ github.sha }} |
There was a problem hiding this comment.
not github.sha. should be the tag so we can have mainnet as latest and mainnet-1.5.0 and mainnet-1.6.0.
we don't usually need mainnet-abcdef for mainnet.
| uses: docker/build-push-action@v6 | ||
| with: | ||
| build-args: | | ||
| RELEASE_TAG=${{ github.sha }} |
| name: 'Base' | ||
| environment: 'Base' | ||
| directory: 'base' | ||
| - id: 'deploy-ethereum.yml' |
There was a problem hiding this comment.
base and ethereum should be trigger after we release the mainnet branc docker image. otherwise they will not be up to date. so you may want to move these to run after update-docker-mainnet
chrisli30
force-pushed
the
staging
branch
2 times, most recently
from
7422b32 to
63bc1de
Compare
…ile such as deploy-base.yml
chrisli30
force-pushed
the
chris-streamline_release
branch
from
47bb934 to
72234c6
Compare
* Re-organize workflows and releasing process * Added Environment details to Release.md * Added commit message naming convension * Change to publish dev docker on PR close * Change to publish dev docker on PR close * Update .github/workflows/deploy-avs.yml so we don’t need individual file such as deploy-base.yml * Added release-on-pr-close.yml * Renamed yaml files * Updated RELEASE.md
* Re-organize workflows and releasing process * Added Environment details to Release.md * Added commit message naming convension * Change to publish dev docker on PR close * Change to publish dev docker on PR close * Update .github/workflows/deploy-avs.yml so we don’t need individual file such as deploy-base.yml * Added release-on-pr-close.yml * Renamed yaml files * Updated RELEASE.md
* Re-organize workflows and releasing process * Added Environment details to Release.md * Added commit message naming convension * Change to publish dev docker on PR close * Change to publish dev docker on PR close * Update .github/workflows/deploy-avs.yml so we don’t need individual file such as deploy-base.yml * Added release-on-pr-close.yml * Renamed yaml files * Updated RELEASE.md
No description provided.