-
Notifications
You must be signed in to change notification settings - Fork 68
implement paymaster support #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devin-ai-integration bot
added a commit
that referenced
this pull request
Mar 28, 2025
Co-Authored-By: Chris Li <chris@avaprotocol.org>
devin-ai-integration bot
added a commit
that referenced
this pull request
Apr 4, 2025
Co-Authored-By: Chris Li <chris@avaprotocol.org>
devin-ai-integration bot
added a commit
that referenced
this pull request
Apr 4, 2025
Co-Authored-By: Chris Li <chris@avaprotocol.org>
devin-ai-integration bot
added a commit
that referenced
this pull request
May 11, 2025
Co-Authored-By: Chris Li <chris@avaprotocol.org>
chrisli30
added a commit
that referenced
this pull request
May 11, 2025
* implement paymaster support * track task counter * Add more test coverage for paymaster functionality (#189) * ai oopise * delete useless test * Add tests for paymaster validation with direct contract call Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix paymaster validation tests to align with PR #188 changes Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix PayMaster contract access in validation tests Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix PayMaster contract access in validation tests Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix TestValidatePaymasterUserOp tests to avoid nil bundler client Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix 'Sender not EntryPoint' error by setting From field in CallMsg to EntryPoint address Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix mocking approach in transaction limit test Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix mocking approach in transaction limit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix SendUserOp mocking approach in transaction limit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix SendUserOp function type and mocking approach Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix transaction limit test by removing redundant function swapping Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestValidatePaymasterUserOpSuccess test to not expect specific validation data Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn test to use mock SendUserOp function Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix time validation in TestTransactionSponsorshipLimit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by adding all required receipt fields in mock Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix Receipt struct fields in mock implementation Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by mocking the entire Execute method Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by using direct mock approach Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix field access in TestContractWriteSimpleReturn Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix type mismatch in TestContractWriteSimpleReturn Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestTransactionSponsorshipLimit test expectations to match implementation Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix paymaster request logic to match test expectations Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Update test expectations for 11th and 20th transactions Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Add clarifying comments based on Copilot suggestions Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix import paths in builder_test.go Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Update go.mod dependencies Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix builder_test.go to use TEST_PRIVATE_KEY instead of CONTROLLER_PRIVATE_KEY Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix builder_test.go to handle missing TEST_PRIVATE_KEY in CI Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Skip network-dependent tests in CI environment Co-Authored-By: Chris Li <chris.li.2046@gmail.com> --------- Co-authored-by: Vinh <vinh@avaprotocol.org> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chris Li <chris@avaprotocol.org> Co-authored-by: Chris Li <chris.li.2046@gmail.com>
chrisli30
added a commit
that referenced
this pull request
May 14, 2025
* implement paymaster support * track task counter * Add more test coverage for paymaster functionality (#189) * ai oopise * delete useless test * Add tests for paymaster validation with direct contract call Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix paymaster validation tests to align with PR #188 changes Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix PayMaster contract access in validation tests Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix PayMaster contract access in validation tests Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix TestValidatePaymasterUserOp tests to avoid nil bundler client Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix 'Sender not EntryPoint' error by setting From field in CallMsg to EntryPoint address Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix mocking approach in transaction limit test Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix mocking approach in transaction limit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix SendUserOp mocking approach in transaction limit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix SendUserOp function type and mocking approach Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix transaction limit test by removing redundant function swapping Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestValidatePaymasterUserOpSuccess test to not expect specific validation data Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn test to use mock SendUserOp function Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix time validation in TestTransactionSponsorshipLimit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by adding all required receipt fields in mock Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix Receipt struct fields in mock implementation Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by mocking the entire Execute method Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by using direct mock approach Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix field access in TestContractWriteSimpleReturn Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix type mismatch in TestContractWriteSimpleReturn Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestTransactionSponsorshipLimit test expectations to match implementation Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix paymaster request logic to match test expectations Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Update test expectations for 11th and 20th transactions Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Add clarifying comments based on Copilot suggestions Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix import paths in builder_test.go Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Update go.mod dependencies Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix builder_test.go to use TEST_PRIVATE_KEY instead of CONTROLLER_PRIVATE_KEY Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix builder_test.go to handle missing TEST_PRIVATE_KEY in CI Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Skip network-dependent tests in CI environment Co-Authored-By: Chris Li <chris.li.2046@gmail.com> --------- Co-authored-by: Vinh <vinh@avaprotocol.org> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chris Li <chris@avaprotocol.org> Co-authored-by: Chris Li <chris.li.2046@gmail.com>
chrisli30
added a commit
that referenced
this pull request
May 21, 2025
* implement paymaster support * track task counter * Add more test coverage for paymaster functionality (#189) * ai oopise * delete useless test * Add tests for paymaster validation with direct contract call Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix paymaster validation tests to align with PR #188 changes Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix PayMaster contract access in validation tests Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix PayMaster contract access in validation tests Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix TestValidatePaymasterUserOp tests to avoid nil bundler client Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix 'Sender not EntryPoint' error by setting From field in CallMsg to EntryPoint address Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix mocking approach in transaction limit test Co-Authored-By: Chris Li <chris@avaprotocol.org> * Fix mocking approach in transaction limit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix SendUserOp mocking approach in transaction limit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix SendUserOp function type and mocking approach Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix transaction limit test by removing redundant function swapping Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestValidatePaymasterUserOpSuccess test to not expect specific validation data Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn test to use mock SendUserOp function Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix time validation in TestTransactionSponsorshipLimit test Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by adding all required receipt fields in mock Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix Receipt struct fields in mock implementation Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by mocking the entire Execute method Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestContractWriteSimpleReturn by using direct mock approach Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix field access in TestContractWriteSimpleReturn Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix type mismatch in TestContractWriteSimpleReturn Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix TestTransactionSponsorshipLimit test expectations to match implementation Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix paymaster request logic to match test expectations Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Update test expectations for 11th and 20th transactions Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Add clarifying comments based on Copilot suggestions Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix import paths in builder_test.go Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Update go.mod dependencies Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix builder_test.go to use TEST_PRIVATE_KEY instead of CONTROLLER_PRIVATE_KEY Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Fix builder_test.go to handle missing TEST_PRIVATE_KEY in CI Co-Authored-By: Chris Li <chris.li.2046@gmail.com> * Skip network-dependent tests in CI environment Co-Authored-By: Chris Li <chris.li.2046@gmail.com> --------- Co-authored-by: Vinh <vinh@avaprotocol.org> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chris Li <chris@avaprotocol.org> Co-authored-by: Chris Li <chris.li.2046@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Base Sepolia deployment:
PayMaster https://sepolia.basescan.org/address/0xd99A660FC95F786ead76FB73C11354f499F13b30
Tx with PayMaster https://sepolia.basescan.org/tx/0x88766a353f9589a501f5fc1c83d63fd002e4759895c7d346c90d6eb6a44e204a