Skip to content

Use DeleteSecret instead of Delete #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Use DeleteSecret instead of Delete #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions protobuf/avs.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions protobuf/avs.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ message BranchNode {
message FilterNode {
// Filter node acts like .select or .filter to pluck out element in an array that evaluate the expression to true
string expression = 1;
// input is the id of the node that
// input is the id of the node that we will fetch its value from and feed into the iteration.
// this input has to be an array. Currently we only know about the error at runtime
string input = 2;
}

Expand Down Expand Up @@ -544,7 +545,7 @@ service Aggregator {
// You can decide whether to grant secret to a single workflow or many workflow, or all of your workflow
// By default, your secret is available across all of your tasks.
rpc CreateSecret(CreateOrUpdateSecretReq) returns (google.protobuf.BoolValue) {};
rpc Delete(DeleteSecretReq) returns (google.protobuf.BoolValue) {};
rpc DeleteSecret(DeleteSecretReq) returns (google.protobuf.BoolValue) {};

// Return all secrets belong to this user. Currently we don't support any fine tune or filter yet.
// Only secret names and config data are returned. The secret value aren't returned.
Expand Down
24 changes: 12 additions & 12 deletions protobuf/avs_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.