Skip to content

Add secrets #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add secrets #101

merged 1 commit into from
Jan 16, 2025

Conversation

v9n
Copy link
Member

@v9n v9n commented Jan 15, 2025

Fix #98

@v9n v9n changed the base branch from main to add-filter-node January 15, 2025 19:06
Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the scope mentioned in the #98 implemented in this PR? It needs to be set when a secret is created.

Also, what is the call of adding a secret?

@v9n
Copy link
Member Author

v9n commented Jan 16, 2025

Is the scope mentioned in the #98 implemented in this PR? It needs to be set when a secret is created.

Also, what is the call of adding a secret?

haven’t implemented the scope or the functionality for adding secrets in this PR yet. The main reason is that I’m not entirely sure how we’d like to handle secret management moving forward, so I’ve deferred implementing that until we have a clearer direction.

For now, the code is designed to allow the use of global secrets that are pre-defined in the configuration. It looks something like this, and additional secrets can be added there as needed:

CleanShot 2025-01-16 at 08 52 40

Could you clarify your vision for how you’d like secret management and the addition/removal of secrets to work? I’d also like to understand more about how you see the scope parameter being used in this context.

I do have my own ideas on this, but right out they already conflicted with the current definition of scope and the approach of using an array to store the secrets (e.g., [secretObj, secretObj, secretObj]). I’d prefer to start with your perspective so we can align and refine the implementation together.

@v9n
Copy link
Member Author

v9n commented Jan 16, 2025

@chrisli30 As dicussed on the chat, this is global secret. Define statically in the config file. Manage by AP. There is no way to dynamically add the global secret through API.

The secret will all have AP_ prefix.

Then we will create another issue to document on how an end-user will create and manage the secret to be used in their project.

@v9n v9n changed the base branch from add-filter-node to main January 16, 2025 20:28
@v9n v9n merged commit 45fb2f3 into main Jan 16, 2025
4 checks passed
@v9n v9n deleted the add-secrets branch January 16, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create secrets.telegram_notify_bot_token so we can use it in the URL of RestApi
2 participants