upgrade to pre-release of mongodb node driver 7 #15697
Open
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Mongoose to use a pre-release version of the MongoDB Node.js driver v7. The main changes involve removing the deprecated noResponse option and adjusting behavior around ObjectId validation and creation with numbers.
- Updated mongodb driver dependency to pre-release version 7
- Removed
noResponseoption fromsyncIndexes()calls, replaced withsparseoption - Updated ObjectId validation to reject numbers as valid ObjectIds
- Added migration guide documentation for breaking changes
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates mongodb driver dependency to v7 pre-release version |
| test/types/models.test.ts | Removes noResponse option from syncIndexes() test cases |
| test/types/base.test.ts | Removes noResponse option from syncIndexes() test cases |
| test/model.query.casting.test.js | Updates ObjectId creation to use string format instead of numbers |
| test/index.test.js | Changes test assertion to expect isValidObjectId() to return false for numbers |
| docs/migrating_to_9.md | Adds documentation for ObjectId validation breaking change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hasezoey
approved these changes
Oct 25, 2025
| function gh12100() { | ||
| mongoose.syncIndexes({ continueOnError: true, noResponse: true }); | ||
| mongoose.syncIndexes({ continueOnError: false, noResponse: true }); | ||
| mongoose.syncIndexes({ continueOnError: true, sparse: true }); |
There was a problem hiding this comment.
This should likely be in the migration guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I needed to make a couple of small adjustments: no more
noResponseoption, and numbers are no longer valid as ObjectIds, but the rest seems to work.Examples